Bug 244846 - multimedia/libvdpau: missing dependency on x11/libX11, etc.
Summary: multimedia/libvdpau: missing dependency on x11/libX11, etc.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-16 15:04 UTC by John Hein
Modified: 2020-03-16 18:20 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2020-03-16 15:04:13 UTC
multimedia/libvdpau is missing a dependency on x11/libX11 and others.

ldd /usr/local/lib/libvdpau.so.1.0.0
/usr/local/lib/libvdpau.so.1.0.0:
        libX11.so.6 => /usr/local/lib/libX11.so.6 (0x801203000)
        libdl.so.1 => /usr/lib/libdl.so.1 (0x80154a000)
        libXext.so.6 => /usr/local/lib/libXext.so.6 (0x80174b000)
        libthr.so.3 => /lib/libthr.so.3 (0x80195c000)
        libc.so.7 => /lib/libc.so.7 (0x800825000)
        libxcb.so.1 => /usr/local/lib/libxcb.so.1 (0x801b85000)
        libXau.so.6 => /usr/local/lib/libXau.so.6 (0x801dab000)
        libXdmcp.so.6 => /usr/local/lib/libXdmcp.so.6 (0x801fae000)


--- Makefile    (revision 528524)
+++ Makefile    (working copy)
@@ -12,7 +12,7 @@

 USES=          localbase meson pkgconfig xorg
 USE_GITLAB=    yes
-USE_XORG=      xext xorgproto
+USE_XORG=      x11 xau xdmcp xext xorgproto
 USE_LDCONFIG=  yes
 GL_SITE=       https://gitlab.freedesktop.org
 GL_ACCOUNT=    vdpau
Comment 1 John Hein 2020-03-16 15:31:26 UTC
I think I would only add x11, not xau & xdmcp.  libvdpau is only directly linked to libX11 & libXext:

ldd -a /usr/local/lib/libvdpau.so.1.0.0
/usr/local/lib/libvdpau.so.1.0.0:
        libX11.so.6 => /usr/local/lib/libX11.so.6 (0x801203000)
        libdl.so.1 => /usr/lib/libdl.so.1 (0x80154a000)
        libXext.so.6 => /usr/local/lib/libXext.so.6 (0x80174b000)
        libthr.so.3 => /lib/libthr.so.3 (0x80195c000)
        libc.so.7 => /lib/libc.so.7 (0x800825000)
/usr/local/lib/libX11.so.6:
        libxcb.so.1 => /usr/local/lib/libxcb.so.1 (0x801b85000)
        libthr.so.3 => /lib/libthr.so.3 (0x80195c000)
        libc.so.7 => /lib/libc.so.7 (0x800825000)
/usr/lib/libdl.so.1:
        libc.so.7 => /lib/libc.so.7 (0x800825000)
/usr/local/lib/libXext.so.6:
        libX11.so.6 => /usr/local/lib/libX11.so.6 (0x801203000)
        libc.so.7 => /lib/libc.so.7 (0x800825000)
/lib/libthr.so.3:
        libc.so.7 => /lib/libc.so.7 (0x800825000)
/usr/local/lib/libxcb.so.1:
        libXau.so.6 => /usr/local/lib/libXau.so.6 (0x801dab000)
        libXdmcp.so.6 => /usr/local/lib/libXdmcp.so.6 (0x801fae000)
        libthr.so.3 => /lib/libthr.so.3 (0x80195c000)
        libc.so.7 => /lib/libc.so.7 (0x800825000)
/usr/local/lib/libXau.so.6:
        libc.so.7 => /lib/libc.so.7 (0x800825000)
/usr/local/lib/libXdmcp.so.6:
        libc.so.7 => /lib/libc.so.7 (0x800825000)


--- Makefile    (revision 528524)
+++ Makefile    (working copy)
@@ -12,7 +12,7 @@

 USES=          localbase meson pkgconfig xorg
 USE_GITLAB=    yes
-USE_XORG=      xext xorgproto
+USE_XORG=      x11 xext xorgproto
 USE_LDCONFIG=  yes
 GL_SITE=       https://gitlab.freedesktop.org
 GL_ACCOUNT=    vdpau
Comment 2 commit-hook freebsd_committer 2020-03-16 18:08:41 UTC
A commit references this bug:

Author: madpilot
Date: Mon Mar 16 18:07:39 UTC 2020
New revision: 528534
URL: https://svnweb.freebsd.org/changeset/ports/528534

Log:
  Add missing dependency on libX11.

  PR:		244846
  Submitted by:	John Hein <jcfyecrayz@liamekaens.com>

Changes:
  head/multimedia/libvdpau/Makefile