Bug 244889 - [PATCH] Make net-mgmt/subcalc fetchable again and update to v1.3
Summary: [PATCH] Make net-mgmt/subcalc fetchable again and update to v1.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Christian S.J. Peron
Depends on:
Reported: 2020-03-18 15:49 UTC by Cy Schubert
Modified: 2020-05-13 02:27 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (csjp)

Make fetchable again and update to v1.3 (2.42 KB, patch)
2020-03-18 15:49 UTC, Cy Schubert
csjp: maintainer-approval+
Details | Diff
Final diff (2.40 KB, patch)
2020-03-18 19:24 UTC, Cy Schubert
cy: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cy Schubert freebsd_committer 2020-03-18 15:49:06 UTC
Created attachment 212499 [details]
Make fetchable again and update to v1.3

This makes net-mgmt/subcalc fetchable again and updates to 1.3.

I didn't have time to make sure this patch complies with the porters handbook, I felt it best to get the PR in now and update the patch if needed later.
Comment 1 Christian S.J. Peron freebsd_committer 2020-03-18 16:07:14 UTC
Comment on attachment 212499 [details]
Make fetchable again and update to v1.3

Looks good to me. Let's change MASTER_SITES to th github page while we are at it.
Comment 2 Cy Schubert freebsd_committer 2020-03-18 16:27:19 UTC
Oops. I should have removed that. MASTER_SITES is not needed with GH.

I should change pkg-descr to point to the GH site too, for README.md.

Gordon asked that I look at an NTP thing at noon (break at $JOB). I'll fix my patch after that.
Comment 3 Cy Schubert freebsd_committer 2020-03-18 19:24:33 UTC
Created attachment 212506 [details]
Final diff

This patch fixes the oops and conforms with https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-master_sites-github-description.

It should be ready for commit.
Comment 4 Cy Schubert freebsd_committer 2020-03-19 05:00:32 UTC
I've committed this to my git repo and will git svn dcommit it tomorrow with a number of other "cached" commits.
Comment 5 commit-hook freebsd_committer 2020-03-19 12:32:44 UTC
A commit references this bug:

Author: cy
Date: Thu Mar 19 12:32:27 UTC 2020
New revision: 528719
URL: https://svnweb.freebsd.org/changeset/ports/528719

  Make fetchable again by pointing to csjp@'s GH repo, which is at v1.3.
  Update from v1.1 to v1.3.

  PR:		244889
  Submitted by:	cy
  Reported by:	cy
  Approved by:	csjp

Comment 6 Cy Schubert freebsd_committer 2020-05-13 02:27:34 UTC