Bug 244911 - mail/rblcheck - unbreak, improve
Summary: mail/rblcheck - unbreak, improve
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2020-03-19 15:52 UTC by Mikhail Teterin
Modified: 2020-04-25 11:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (moro)


Attachments
Unbreak, improve (5.74 KB, patch)
2020-03-19 15:52 UTC, Mikhail Teterin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer 2020-03-19 15:52:51 UTC
Created attachment 212528 [details]
Unbreak, improve

The original SourceForge project has moved to GitHub a while ago, and the port is now broken.

The GitHub code -- unmodified in 18 years (!) -- is almost the same as what the original distfile contained except:

  1. No more configure -- only configure.in
  2. No more RCS variables in code -- git does not support them.
  3. configure.in contains code to find res_query on Cygwin (!), which breaks on   
     FreeBSD

Instead of trying to configure.in -- so that the sole C file can be built with gmake, this patch switches to a bsd.prog.mk.

The corrected version of upstream's rbl.in moves into files/ too -- to be handled by the SUB_FILES-mechanism.

The DOCS-option is removed -- it was never handled properly anyway, and the author does not include useful documentation beyond the program's usage(). Other useless files are omitted too.

Finally, a couple of warnings are fixed in the C-code itself to qualify for WARNS=2.
Comment 1 commit-hook freebsd_committer 2020-04-25 11:42:39 UTC
A commit references this bug:

Author: arrowd
Date: Sat Apr 25 11:42:32 UTC 2020
New revision: 532940
URL: https://svnweb.freebsd.org/changeset/ports/532940

Log:
  mail/rblcheck: Unbreak the port.

  PR:		244911
  Submitted by:	mi

Changes:
  head/mail/rblcheck/Makefile
  head/mail/rblcheck/distinfo
  head/mail/rblcheck/files/BSDmakefile
  head/mail/rblcheck/files/patch-rblcheck.c
  head/mail/rblcheck/files/rbl.in
  head/mail/rblcheck/pkg-plist