Bug 244939 - [exp-run] Remove procfs-based process debugging
Summary: [exp-run] Remove procfs-based process debugging
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-20 22:06 UTC by John Baldwin
Modified: 2020-04-15 16:22 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Baldwin freebsd_committer freebsd_triage 2020-03-20 22:06:50 UTC
Can you please run an exp-run for head with https://reviews.freebsd.org/D23837 patched?  Note that you will need a head that is at r359054 or later for the patch to apply cleanly.

I promise I just ran a fresh make tinderbox, so this one should build world the first time.
Comment 1 Antoine Brodin freebsd_committer 2020-03-28 22:02:45 UTC
There is 1 new failure:  devel/strace

Failure log:

http://package23.nyi.freebsd.org/data/headi386PR244939-default/2020-03-27_06h45m06s/logs/errors/strace-4.5.18_1.log
Comment 2 John Baldwin freebsd_committer freebsd_triage 2020-03-31 21:58:33 UTC
Thanks, strace will have to be marked BROKEN on 13.  It uses the procfs debugging instead of ptrace().  It's also i386 only, and it's functionality should already be available via in-tree truss.
Comment 3 commit-hook freebsd_committer 2020-04-01 19:22:57 UTC
A commit references this bug:

Author: jhb
Date: Wed Apr  1 19:22:15 UTC 2020
New revision: 359530
URL: https://svnweb.freebsd.org/changeset/base/359530

Log:
  Retire procfs-based process debugging.

  Modern debuggers and process tracers use ptrace() rather than procfs
  for debugging.  ptrace() has a supserset of functionality available
  via procfs and new debugging features are only added to ptrace().
  While the two debugging services share some fields in struct proc,
  they each use dedicated fields and separate code.  This results in
  extra complexity to support a feature that hasn't been enabled in the
  default install for several years.

  PR:		244939 (exp-run)
  Reviewed by:	kib, mjg (earlier version)
  Relnotes:	yes
  Differential Revision:	https://reviews.freebsd.org/D23837

Changes:
  head/ObsoleteFiles.inc
  head/lib/libsysdecode/Makefile
  head/sys/amd64/amd64/trap.c
  head/sys/amd64/amd64/vm_machdep.c
  head/sys/amd64/ia32/ia32_reg.c
  head/sys/amd64/ia32/ia32_signal.c
  head/sys/amd64/ia32/ia32_syscall.c
  head/sys/arm/arm/syscall.c
  head/sys/arm64/arm64/trap.c
  head/sys/compat/ia32/ia32_sysvec.c
  head/sys/conf/files
  head/sys/fs/procfs/procfs.c
  head/sys/fs/procfs/procfs.h
  head/sys/fs/procfs/procfs_ioctl.c
  head/sys/i386/i386/trap.c
  head/sys/i386/i386/vm_machdep.c
  head/sys/kern/imgact_elf.c
  head/sys/kern/kern_exec.c
  head/sys/kern/kern_exit.c
  head/sys/kern/kern_fork.c
  head/sys/kern/kern_prot.c
  head/sys/kern/kern_sig.c
  head/sys/kern/kern_thread.c
  head/sys/kern/subr_syscall.c
  head/sys/kern/subr_trap.c
  head/sys/kern/sys_process.c
  head/sys/mips/mips/trap.c
  head/sys/modules/procfs/Makefile
  head/sys/powerpc/powerpc/trap.c
  head/sys/riscv/riscv/trap.c
  head/sys/sys/param.h
  head/sys/sys/pioctl.h
  head/sys/sys/proc.h
Comment 4 John Baldwin freebsd_committer freebsd_triage 2020-04-01 19:24:22 UTC
Patch to mark devel/strace BROKEN:

https://reviews.freebsd.org/D24254
Comment 5 commit-hook freebsd_committer 2020-04-15 16:22:37 UTC
A commit references this bug:

Author: jhb
Date: Wed Apr 15 16:22:16 UTC 2020
New revision: 531773
URL: https://svnweb.freebsd.org/changeset/ports/531773

Log:
  Mark devel/strace as broken on 13.0 and later.

  FreeBSD 13 removes procfs-based process debugging which strace(1)
  uses.  Users can use truss in the base system instead.

  PR:		244939
  Reviewed by:	sbz (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D24254

Changes:
  head/devel/strace/Makefile