Bug 244955 - security/gopass: gopass new UI is broken with 1.8.6
Summary: security/gopass: gopass new UI is broken with 1.8.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ashish SHUKLA
URL: https://github.com/gopasspw/gopass/is...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-21 15:29 UTC by Ashish SHUKLA
Modified: 2020-03-22 05:56 UTC (History)
1 user (show)

See Also:
sascha: maintainer-feedback+


Attachments
diff to fix the mentioned issue (10.18 KB, patch)
2020-03-21 15:29 UTC, Ashish SHUKLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ashish SHUKLA freebsd_committer 2020-03-21 15:29:43 UTC
Created attachment 212585 [details]
diff to fix the mentioned issue

When executing "gopass new" (built with Go 1.14), UI stalls, no response to cursor movement or anything.

It's been reported upstream as: https://github.com/gopasspw/gopass/issues/1226

The attached diff fixes it, and also fixes portlint complaints by reordering ONLY_FOR_ARCHS{,_REASON} lines.
Comment 1 Sascha Holzleiter 2020-03-21 21:20:39 UTC
Back when i opened this bug report and also talked on the gopass IRC channel about it i really hoped there would be an upstream fix soon :( 

I'm a bit reluctant to patch this in the port. The workaround works for now but it also replaces a core library of the application. So if we patch this now in the port we might have to adapt this to future code changes. That was the reason for not updating the port until now.

As other people now seem to notice and project development seems to have somewhat stalled it might be best to patch the port and deal with the code change situation if there is ever a new release.

So i'm ok with committing this, thanks for the patch!
Comment 2 commit-hook freebsd_committer 2020-03-22 05:51:34 UTC
A commit references this bug:

Author: ashish
Date: Sun Mar 22 05:50:31 UTC 2020
New revision: 528898
URL: https://svnweb.freebsd.org/changeset/ports/528898

Log:
  - Add patches to fix brokenness in curses UI
  - Pet portlint

  PR:		244955
  Approved by:	Sascha Holzleiter <sascha at root-login dot org> (maintainer)

Changes:
  head/security/gopass/Makefile
  head/security/gopass/files/
  head/security/gopass/files/patch-vendor_github.com_gdamore_tcell_termbox_compat.go
  head/security/gopass/files/patch-vendor_github.com_jroimartin_gocui_gui.go
  head/security/gopass/files/patch-vendor_github.com_jroimartin_gocui_keybinding.go
Comment 3 Ashish SHUKLA freebsd_committer 2020-03-22 05:53:17 UTC
(In reply to Sascha Holzleiter from comment #1)

Committed, and thanks for approving the changes. Once upstream has implemented fixes for this problem, we can purge these local patches.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2020-03-22 05:56:42 UTC
^Triage: Assign to committer that resolved