Bug 244983 - sysutils/py-glances: Update to 3.1.4
Summary: sysutils/py-glances: Update to 3.1.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
Keywords: buildisok, needs-qa
Depends on:
Reported: 2020-03-22 18:59 UTC by Muhammad Moinur Rahman
Modified: 2020-05-26 20:55 UTC (History)
2 users (show)

See Also:
gasol.wu: maintainer-feedback+

Update version 3.1.4 (865 bytes, patch)
2020-03-22 18:59 UTC, Muhammad Moinur Rahman
no flags Details | Diff
Update version 3.1.4 (1.77 KB, patch)
2020-03-23 19:09 UTC, Muhammad Moinur Rahman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Muhammad Moinur Rahman freebsd_committer 2020-03-22 18:59:54 UTC
Created attachment 212618 [details]
Update version 3.1.4
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-03-22 23:48:09 UTC
^Triage: Reporter is committer, assign accordingly
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-03-22 23:53:46 UTC
Package installs files/scripts into non python specific locations [1] but the port doesnt use concurrent to make these concurrent installation safe. Add USE_PYTHON=concurrent and verify pkg-plist

Package also provides a test suite [2], would be great to add TEST_DEPENDS and a test target to improve QA substantially.

Package only declares and tests against 2.7 and 3.6, verify tests pass on versions > 3.6 else limit version support to -3.6. If it passes on > 3.6 ask upstream to test against these versions

[1] setup.py:entry_points={"console_scripts": ["glances=glances:main"]},
[2] setup.py:test_suite="unitest.py",
Comment 3 Automation User 2020-03-23 01:00:09 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/128609246
Comment 4 Muhammad Moinur Rahman freebsd_committer 2020-03-23 19:09:23 UTC
Created attachment 212651 [details]
Update version 3.1.4

comment # 2
Fixed accordingly
Comment 5 commit-hook freebsd_committer 2020-05-26 20:54:42 UTC
A commit references this bug:

Author: bofh
Date: Tue May 26 20:54:04 UTC 2020
New revision: 536654
URL: https://svnweb.freebsd.org/changeset/ports/536654

  sysutils/py-glances: Update version 3.1.3=>3.1.4

  - Add TEST_DEPENDS and test framework
  - Update support for python upto 3.6
  - Make use of ETCDIR

  PR:		244983
  Approved by:	gasol.wu@gmail.com (MAINTAINER)