Bug 245004 - net-im/telegram-desktop: Fix build on CURRENT with clang 10
Summary: net-im/telegram-desktop: Fix build on CURRENT with clang 10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-23 08:57 UTC by Guido Falsi
Modified: 2020-03-23 12:45 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (henry.hu.sh)


Attachments
patch (3.24 KB, patch)
2020-03-23 08:57 UTC, Guido Falsi
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer 2020-03-23 08:57:58 UTC
Created attachment 212639 [details]
patch

telegram-desktop fails to build on head after the update to telegram 10.

I created a patch to make it build.

The patch to the bundled rapidjson in the rlottie third party library comes from upstream:

https://github.com/Tencent/rapidjson/commit/2661a17c7eaede8c881e7455f5a66fd593ed8633#diff-4a56fc9353bac10cf2f51e22e38e3b2a

The patch to the lib_base/base/thread_safe_wrap.h file I created. AFAIK it should be a NOP for previous clang versions which silently apply the same cast, while clang 10 is stricter and casts a warning.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-03-23 09:10:59 UTC
Comment on attachment 212639 [details]
patch

Approved by: portmgr (blanket: build/run fix)
Comment 2 commit-hook freebsd_committer 2020-03-23 12:43:51 UTC
A commit references this bug:

Author: madpilot
Date: Mon Mar 23 12:43:40 UTC 2020
New revision: 528972
URL: https://svnweb.freebsd.org/changeset/ports/528972

Log:
  Fix build with clang 10

  PR:		245004
  Obtained from:	https://github.com/Tencent/rapidjson/commit/2661a17c7eaede8c881e7455f5a66fd593ed8633#diff-4a56fc9353bac10cf2f51e22e38e3b2a (part)
  Approved by:	portmgr (blanket)

Changes:
  head/net-im/telegram-desktop/files/patch-Telegram_ThirdParty_rlottie_src_lottie_rapidjson_document.h
  head/net-im/telegram-desktop/files/patch-Telegram_lib__base_base_thread__safe__wrap.h
Comment 3 Guido Falsi freebsd_committer 2020-03-23 12:45:37 UTC
Committed.