Bug 245032 - databases/kyototycoon: Remove CPU-specific optimisation
Summary: databases/kyototycoon: Remove CPU-specific optimisation
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-24 09:34 UTC by Dave Cottlehuber
Modified: 2020-03-24 09:54 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)
koobs: merge-quarterly?


Attachments
swap out native optimisation for O3 (1.15 KB, patch)
2020-03-24 09:34 UTC, Dave Cottlehuber
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Cottlehuber freebsd_committer 2020-03-24 09:34:02 UTC
Created attachment 212675 [details]
swap out native optimisation for O3

depending on the specific cpu stepping for the poudriere build server vs the actual deployed server, some optimisations produce a SIGILL on startup, or elsewhere such as during snapshots. This is very frustrating for a database to dump core and lose all data.

Testing: 11.3R and 12.1R and 13.0R all amd64 are fine.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-03-24 09:54:14 UTC
@Dave As ports should not produce build machine specific code, this change is:

Approved by: portmgr (blanket: ports/framework compliance)

The defacto mechanism for this is "-native removal" as has been done in the patch, but also using OPTIMIZED_CFLAGS option (in bsd.options.desc.mk already) which then adds -OX etc etc. If there are any other optimizations done, they shoudl also be removed
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-03-24 09:54:25 UTC
Comment on attachment 212675 [details]
swap out native optimisation for O3

Approved by: portmgr (blanket: ports/framework compliance)

Pending QA