Bug 245052 - graphics/geeqie: fails to build when MAKE_JOBS_NUMBER is set
Summary: graphics/geeqie: fails to build when MAKE_JOBS_NUMBER is set
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-25 12:55 UTC by Samy Mahmoudi
Modified: 2020-03-29 20:51 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
Poudriere testport log (lightened) (434.03 KB, text/plain)
2020-03-25 13:00 UTC, Samy Mahmoudi
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Samy Mahmoudi 2020-03-25 12:55:40 UTC
Hi Dmitry,

geeqie fails to build when MAKE_JOBS_NUMBER is set. I have added the following three lines to my poudriere's make.conf to circumvent the problem.

.if $(.CURDIR:M*/graphics/geeqie)
MAKE_JOBS_UNSAFE=yes
.endif

This is clearly a nonurgent bug but I am wondering why geeqie fails building in parallel whereas the other 900+ ports I build do not.
Comment 1 Samy Mahmoudi 2020-03-25 13:00:07 UTC
Created attachment 212700 [details]
Poudriere testport log (lightened)
Comment 2 Dmitry Marakasov freebsd_committer 2020-03-29 17:03:48 UTC
How many jobs do you use?
Comment 3 Dmitry Marakasov freebsd_committer 2020-03-29 17:56:27 UTC
Also please (always) post the full build log.
And try after 529819.
Comment 4 Dmitry Marakasov freebsd_committer 2020-03-29 18:05:55 UTC
Also reported upstream: https://github.com/BestImageViewer/geeqie/issues/766
Comment 5 commit-hook freebsd_committer 2020-03-29 18:06:17 UTC
A commit references this bug:

Author: amdmi3
Date: Sun Mar 29 17:56:07 UTC 2020
New revision: 529819
URL: https://svnweb.freebsd.org/changeset/ports/529819

Log:
  Attempt to fix parallel build

  PR:		245052
  Submitted by:	samy.mahmoudi@gmail.com

Changes:
  head/graphics/geeqie/Makefile
Comment 6 Samy Mahmoudi 2020-03-29 19:34:44 UTC
(In reply to Dmitry Marakasov from comment #2)
I use MAKE_JOBS_NUMBER=16.
Comment 7 Samy Mahmoudi 2020-03-29 20:14:24 UTC
(In reply to Dmitry Marakasov from comment #3)
Sorry for that, the file size exceeded the maximum file size allowed. Here is the full log:

http://imp.ovh/geeqie-1.5.1_3.log
Comment 8 Samy Mahmoudi 2020-03-29 20:27:28 UTC
(In reply to Dmitry Marakasov from comment #3)
I can confirm that revision 529819 builds fine with MAKE_JOBS_NUMBER=16 and that reverting the changes makes the build fail again.
Comment 9 Samy Mahmoudi 2020-03-29 20:28:56 UTC
(In reply to commit-hook from comment #5)
Therefore your "attempt" is successful. Thank you!
Comment 10 Dmitry Marakasov freebsd_committer 2020-03-29 20:51:15 UTC
> Therefore your "attempt" is successful. Thank you!

Great, will try to resolve this with upstream as well.