Bug 245151 - Deactivate Autoassigner when Flags are set
Summary: Deactivate Autoassigner when Flags are set
Status: In Progress
Alias: None
Product: Services
Classification: Unclassified
Component: Bug Tracker (show other bugs)
Version: unspecified
Hardware: Any Any
: --- Affects Only Me
Assignee: Oleksandr Tymoshenko
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-03-28 19:56 UTC by Tobias C. Berner
Modified: 2020-09-02 15:59 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias C. Berner freebsd_committer 2020-03-28 19:56:46 UTC
Moin moin 

The bugzilla auto assigner should get deactivated when the bug has the flags 
- exp-run 
and the assignee is 
- portmgr@FreeBSD.org

Otherwise, you'll always have to get back to the PR and reassign it to portmgr... takes only a minute, but gets a bit old after the 20st time...


mfg Tobias
Comment 1 Tobias C. Berner freebsd_committer 2020-04-28 18:41:43 UTC
Ping?
Comment 2 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2020-04-28 18:42:39 UTC
I'll look into it
Comment 3 Tobias C. Berner freebsd_committer 2020-04-28 18:45:15 UTC
(In reply to Oleksandr Tymoshenko from comment #2)
Thank you :)
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2020-04-29 02:51:42 UTC
Special cases should be avoided in autoassigner whereever possible

I'd rather describe this in terms of the implicitly stated goal, which appears ostensibly to be "that issues that need exp-runs need not be *manually assigned* to portmgr"

At present the implemented exp-run mechanism is pull-based (not push based), and in particular, already setup such that portmgr is notified when that flag is set (see screenshot).

The only thing that actually needs to be done is to set the flag, which already happens. That the issue may be Assigned to the current maintainer does not get in the way of portmgr self-assigning issues as they go through the exp run request queue
Comment 5 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2020-04-29 23:01:24 UTC
(In reply to Kubilay Kocak from comment #4)

Since I am not familiar with ports or portmgr workflow, I'll let you decide what is actually required. From the implementation point of view, it's not hard to add.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2020-06-10 05:34:00 UTC
Hi Tobias,

Can you add some issues that were examples of where the AA behaviour wasn't optimal in your opinion to this issues See Also field please

I'm guessing this is also only an issue when the MAINTAINER is also a committer (@freebsd.org), as this is the only time when AA changes Assignee. Is that correct?
Comment 7 Tobias C. Berner freebsd_committer 2020-06-10 14:43:41 UTC
(In reply to Kubilay Kocak from comment #6)
Moin moin 

Here are three recent examples:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246990
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246848
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246847


mfg Tobias
Comment 8 Tobias C. Berner freebsd_committer 2020-07-03 06:47:18 UTC
Here's another one:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247730


mfg Tobias
Comment 9 Tobias C. Berner freebsd_committer 2020-07-11 20:40:33 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247925
Comment 10 Tobias C. Berner freebsd_committer 2020-08-23 17:51:51 UTC
Moin moin

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248854
... can I do anything to help here?

Because this really starts to get on my nerves :)


mfg Tobias
Comment 11 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2020-08-24 21:58:42 UTC
(In reply to Tobias C. Berner from comment #10)

Hi Tobias,

Sorry for the delay. I deployed possible fix. Please let me know if it works for you.
Comment 12 Tobias C. Berner freebsd_committer 2020-09-02 15:59:50 UTC
(In reply to Oleksandr Tymoshenko from comment #11)
Hi Oleksandr

Thank you very much! 

It seems your change worked, as pr 249060 was not bounced back to me :)


mfg Tobias