Bug 245255 - security/p5-Crypt-X509: Update to 0.52
Summary: security/p5-Crypt-X509: Update to 0.52
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ashish SHUKLA
URL: https://metacpan.org/release/MRSCOTTY...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-04-01 21:53 UTC by Sergei Vyshenski
Modified: 2020-04-02 19:30 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ashish)
svysh.fbsd: maintainer-feedback? (svysh.fbsd)


Attachments
patch to update the port (1.19 KB, patch)
2020-04-01 21:53 UTC, Sergei Vyshenski
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Vyshenski 2020-04-01 21:53:28 UTC
Created attachment 212954 [details]
patch to update the port

- update 0.51_1 -> 0.52
Changes: https://metacpan.org/changes/release/MRSCOTTY/Crypt-X509-0.52
- LICENSE is UNKNOWN, but poudriere is not happy about this value,
	so commented it out.
- "portlint -AC" gives non-relevant warns.
- Tested with:
12.1-RELEASE-p2 amd64
poudriere 3.3.3
perl 5.30.2
pkg 1.13.2
ssl=base
- built-in perl tests in a clean poudriere jail say PASS.
Comment 1 Ashish SHUKLA freebsd_committer 2020-04-02 18:21:50 UTC
(In reply to Sergei Vyshenski from comment #0)

Hi,

Thanks for the diff. I have a question, when you say poudriere is not happy about this value, what do you mean exactly ? I tried on poudriere, and following warning is printed but that gets printed with commented LICENSE value too:

=======================<phase: check-sanity   >============================
/!\ p5-Crypt-X509-0.52: Makefile warnings, please consider fixing /!\

Please set LICENSE for this port

So I'm not sure how that makes any difference.

Thanks!
Comment 2 Sergei Vyshenski 2020-04-02 18:43:13 UTC
If I set 
LICENSE=        UNKNOWN
or
LICENSE=        NONE
I get this from poudriere:

=>> Status   security/p5-Crypt-X509 | p5-Crypt-X509-0.52: check-sanity
=======================<phase: check-sanity   >============================
===>  p5-Crypt-X509-0.52 License UNKNOWN needs confirmation, but BATCH is
defined.
*** Error code 1
Stop.
make: stopped in /usr/ports/security/p5-Crypt-X509
Comment 3 Ashish SHUKLA freebsd_committer 2020-04-02 19:24:08 UTC
(In reply to Sergei Vyshenski from comment #2)

That's what I get too. So, lets not add LICENSE information commented/uncommented. Commented version generations portlint warnings. I will commit the rest of the patch.

Thanks!
Comment 4 Ashish SHUKLA freebsd_committer 2020-04-02 19:30:37 UTC
Committed.

Thanks!
Comment 5 commit-hook freebsd_committer 2020-04-02 19:30:55 UTC
A commit references this bug:

Author: ashish
Date: Thu Apr  2 19:30:18 UTC 2020
New revision: 530402
URL: https://svnweb.freebsd.org/changeset/ports/530402

Log:
  - Update to 0.52

  PR:		245255
  Submitted by:	Sergei Vyshenski <svysh.fbsd@gmail.com>

Changes:
  head/security/p5-Crypt-X509/Makefile
  head/security/p5-Crypt-X509/distinfo