Bug 245287 - ports-mgmt/pkg: pkgcmd=@prefix@/sbin/pkg in periodic scripts
Summary: ports-mgmt/pkg: pkgcmd=@prefix@/sbin/pkg in periodic scripts
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-pkg mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-02 17:15 UTC by VVD
Modified: 2020-04-02 18:08 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (pkg)


Attachments
Fix (1.17 KB, patch)
2020-04-02 17:30 UTC, Ashish SHUKLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description VVD 2020-04-02 17:15:35 UTC
All periodic files:
etc/periodic/weekly/400.status-pkg
etc/periodic/daily/411.pkg-backup
etc/periodic/daily/490.status-pkg-changes
etc/periodic/security/410.pkg-audit
etc/periodic/security/460.pkg-checksum
have pkgcmd=@prefix@/sbin/pkg after install instead pkgcmd=/usr/local/sbin/pkg.
Comment 1 Ashish SHUKLA freebsd_committer 2020-04-02 17:30:57 UTC
Created attachment 212985 [details]
Fix

${WRKSRC}/scripts/Makefile{,.autosetup} seems to expect GNU Make as it's using $(VARIABLE) instead of ${VARIABLE}.

The attached diff performs the substitution in the configure phase instead.
Comment 2 Baptiste Daroussin freebsd_committer 2020-04-02 18:08:29 UTC
no this has nothing to do with GNU make

$() is actually POSIX make. and supported by both GNU make and BSD make
The makefile are mine btw and autosetup's one.

But is fixed in pkg 1.14.1

https://github.com/freebsd/pkg/commit/166a612b767b4bc0fd0bdc9abefcecd4b18e7ab6

Thank you for reporting