Bug 245415 - misc/ctm: ctm fails to correctly set mode of files
Summary: misc/ctm: ctm fails to correctly set mode of files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Stefan Eßer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-07 02:17 UTC by Stephen Montgomery-Smith
Modified: 2020-04-20 12:23 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (se)
koobs: merge-quarterly?


Attachments
Patch to fix problem. (2.36 KB, patch)
2020-04-07 02:17 UTC, Stephen Montgomery-Smith
koobs: maintainer-approval? (se)
Details | Diff
patch as sms mailed jhs 2020-04-07T01:24:42+00 (2.52 KB, patch)
2020-04-07 12:17 UTC, jhs
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Montgomery-Smith freebsd_committer 2020-04-07 02:17:41 UTC
Created attachment 213142 [details]
Patch to fix problem.

ctm fails to use the file mode listed in the ctm delta.  This became a problem in src-cur.14427 when the file contrib/kyua/doc/manbuild.sh was created with mode 755.
Comment 1 jhs 2020-04-07 12:08:11 UTC
Stephen's patch he mailed Juian=jhs@ fixes the problem. Thanks!
Uploading as ddd_2020-04-07T01:24:42+00_email
as its bigger than the ddd Stephen uploaded to freebsd.org/bugzilla
2579  ddd_2020-04-07T01:24:42+00_email
2416  ddd_2020-04-07T02:17+00_bugzilla
Stephen will know which patch is newest/best.
Comment 2 jhs 2020-04-07 12:17:16 UTC
Created attachment 213152 [details]
patch as sms mailed jhs 2020-04-07T01:24:42+00
Comment 3 Stephen Montgomery-Smith freebsd_committer 2020-04-07 23:18:20 UTC
The patch I sent with the original problem report is better than the one I sent to jhs.  But only in that it is more efficiently coded - they both do the same thing.
Comment 4 commit-hook freebsd_committer 2020-04-20 12:21:09 UTC
A commit references this bug:

Author: se
Date: Mon Apr 20 12:20:13 UTC 2020
New revision: 532201
URL: https://svnweb.freebsd.org/changeset/ports/532201

Log:
  Make ctm use the file mode listed in the CTM delta.

  PR:		245415
  Submitted by:	stephen
  Approved by:	antoine (implicit)

Changes:
  head/misc/ctm/Makefile
  head/misc/ctm/files/patch-ctm_ctm__pass3.c
Comment 5 Stefan Eßer freebsd_committer 2020-04-20 12:23:07 UTC
I have applied the first patch, as requested in comment #3.

Please test the updated port (r532201).