Bug 245435 - graphics/drm-devel-kmod: install sources
Summary: graphics/drm-devel-kmod: install sources
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
Depends on:
Reported: 2020-04-07 20:53 UTC by chardon.frederic
Modified: 2020-09-17 09:50 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (x11)

drm-devel-kmod.diff (137.78 KB, patch)
2020-04-07 20:53 UTC, chardon.frederic
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chardon.frederic 2020-04-07 20:53:44 UTC
Created attachment 213166 [details]

Use the same approach as for graphics/drm-current-kmod as of: https://reviews.freebsd.org/D20990
So that pkg users can always have matching kernel and modules.
Comment 1 Niclas Zeising freebsd_committer 2020-04-08 06:59:49 UTC
This has caused issues when done with drm-current-kmod.  We're still evaluating if this is the right approach, or if we should take a different approach, so I don't think this should be committed right now.
Comment 2 chardon.frederic 2020-04-09 07:46:17 UTC
(In reply to Niclas Zeising from comment #1)
What issues? I ask because because I never had any with drm-current and wanted to switch to drm-devel. I don't know where discussion is taking place, but there is at least one user satisfied with this approach :)
Feel free to close this PR, for now I'll just clone the drm repos in ${PREFIX}/sys/modules
Comment 3 Niclas Zeising freebsd_committer 2020-05-03 16:38:25 UTC
There has been several issues with drm-current-kmod when it installs sources.  Most notably is confusion between the running version and the ports version, since the port is perhaps updated after the kernel is updated, but that means the modules won't be updated, since /boot/kernel is preferred over /boot/modules.
There's also the problem where you need updated drm-kmod sources to build with an updated kernel, and if the port isn't updated before the kernel, this can cause build failures.
Comment 4 Niclas Zeising freebsd_committer 2020-09-17 09:50:15 UTC
The option to install sources with ports kmods and then have them rebuilt with build kernel has caused several issues in the past.  drm-current-kmod still has this option, but until issues are sorted, I think it is a bad idea to duplicate it for drm-devel-kmod.