Bug 245517 - net/freerdp: Update to 2.1.1
Summary: net/freerdp: Update to 2.1.1
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Kyle Evans
URL: https://github.com/FreeRDP/FreeRDP/re...
Keywords: needs-qa, security
Depends on:
Blocks:
 
Reported: 2020-04-10 19:40 UTC by VVD
Modified: 2020-05-28 02:52 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (kevans)
koobs: merge-quarterly?


Attachments
Update to 2.0.0 (5.00 KB, patch)
2020-04-10 19:40 UTC, VVD
no flags Details | Diff
Update to 2.1.0 (6.25 KB, patch)
2020-05-15 18:39 UTC, VVD
no flags Details | Diff
Update to 2.1.1 (6.25 KB, patch)
2020-05-25 18:37 UTC, VVD
no flags Details | Diff
Update to 2.1.1 (7.42 KB, patch)
2020-05-27 20:21 UTC, VVD
kevans: maintainer-approval+
Details | Diff
svn(1) diff against the ports tree (1.65 KB, patch)
2020-05-28 00:44 UTC, Kyle Evans
no flags Details | Diff
Proposed vuxml entry (1.76 KB, patch)
2020-05-28 00:46 UTC, Kyle Evans
koobs: maintainer-approval? (koobs)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description VVD 2020-04-10 19:40:46 UTC
Created attachment 213259 [details]
Update to 2.0.0

FreeRDP 2.0.0 require newer version of libusb compared to base system have.
There are several errors during build.

1. Undeclared LIBUSB_CLASS_PHYSICAL, patch (hack?) is:
--- channels/urbdrc/client/libusb/libusb_udevice.h.orig
+++ channels/urbdrc/client/libusb/libusb_udevice.h
@@ -75,4 +75,8 @@
                            BYTE dev_number);
 const char* usb_interface_class_to_string(uint8_t class);
 
+#ifndef LIBUSB_CLASS_PHYSICAL
+#define LIBUSB_CLASS_PHYSICAL 5
+#endif
+
 #endif /* FREERDP_CHANNEL_URBDRC_CLIENT_LIBUSB_UDEVICE_H */

2. Undeclared LIBUSB_CAP_HAS_HOTPLUG - doesn't know how to do better than just add:
#ifndef LIBUSB_CAP_HAS_HOTPLUG
#define LIBUSB_CAP_HAS_HOTPLUG 0x0001
#endif

3. No include file mntent.h - got solution from devel/fam.

4. Undeclared O_TMPFILE in FreeBSD. Fix is here: 
PATCHFILES=     3929226.patch:-p1
https://github.com/FreeRDP/FreeRDP/commit/39292268308a3fd6233c2863df22232725d22b3a

--- a/uwac/libuwac/uwac-os.c
+++ b/uwac/libuwac/uwac-os.c
@@ -33,6 +33,11 @@
 #define USE_SHM
 #endif
 
+/* uClibc and uClibc-ng don't provide O_TMPFILE */
+#ifndef O_TMPFILE
+#define O_TMPFILE (020000000 | O_DIRECTORY)
+#endif
+
 #include <sys/types.h>
 #include <sys/socket.h>
 #ifdef USE_SHM

5. Doesn't know is msusb.h needed - it was moved in sources, and I removed it from pkg-plist.

After that it build fine and connect via rdp to server. Tested on 12.1 amd64.
Comment 1 Kyle Evans freebsd_committer 2020-04-10 19:49:15 UTC
Looping hselasky@ in on this for points #1 and #2, as he's the libusb maintainer.
Comment 2 VVD 2020-05-15 18:39:11 UTC
Created attachment 214534 [details]
Update to 2.1.0

Released 2.1.0 with a lot of CVE fixed:

# 2020-05-05  Version 2.1.0
Important notes:
* fix multiple CVEs: CVE-2020-11039, CVE-2020-11038, CVE-2020-11043, CVE-2020-11040, CVE-2020-11041, CVE-2020-11019, CVE-2020-11017, CVE-2020-11018

# 2020-04-09  Version 2.0.0
Important notes:
* fix multiple CVEs: CVE-2020-11521 CVE-2020-11522 CVE-2020-11523 CVE-2020-11524 CVE-2020-11525 CVE-2020-11526

https://github.com/FreeRDP/FreeRDP/blob/2.1.0/ChangeLog
Comment 3 VVD 2020-05-25 18:37:50 UTC
Created attachment 214848 [details]
Update to 2.1.1

More CVEs.
2020-05-20 Version 2.1.1:
* CVE: GHSL-2020-100 OOB Read in ntlm_read_ChallengeMessage
* CVE: GHSL-2020-101 OOB Read in security_fips_decrypt due to uninitialized value
* CVE: GHSL-2020-102 OOB Write in crypto_rsa_common
Comment 4 VVD 2020-05-27 20:21:08 UTC
Created attachment 214934 [details]
Update to 2.1.1

It was old file.
Comment 5 Kyle Evans freebsd_committer 2020-05-28 00:44:12 UTC
Created attachment 214940 [details]
svn(1) diff against the ports tree

Proposed VuXML entry.
Comment 6 Kyle Evans freebsd_committer 2020-05-28 00:46:22 UTC
Created attachment 214941 [details]
Proposed vuxml entry

Include the 2.1.1 vulns, too
Comment 7 Kyle Evans freebsd_committer 2020-05-28 00:50:38 UTC
FreeRDP patch LGTM; CC'ing koobs@ as my mentor. Can you confirm that you've ran this through testport?

i was hoping Hans would pitch in on the libusb-related part, but alas; I'll poke him about it afterwards.