Bug 245593 - sysutils/yadm: Add optional jinja2-cli runtime depends
Summary: sysutils/yadm: Add optional jinja2-cli runtime depends
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: buildisok
Depends on: 245783
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-13 12:02 UTC by Adam Jimerson
Modified: 2020-04-21 12:47 UTC (History)
1 user (show)

See Also:


Attachments
Add optional py-jinja2-cli depends (645 bytes, patch)
2020-04-13 12:02 UTC, Adam Jimerson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Jimerson 2020-04-13 12:02:43 UTC
Created attachment 213362 [details]
Add optional py-jinja2-cli depends

Add a new optional runtime dependency on textproc/py-jinja2-cli which can be enabled by a user when compiling from ports to allow the use of Jinja2 templates.
Comment 1 Automation User 2020-04-13 12:44:17 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/135362119
Comment 2 Fernando Apesteguía freebsd_committer 2020-04-15 05:37:32 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval

Attachment -> Details -> maintainer-approval [+]

Thanks!
Comment 3 Adam Jimerson 2020-04-15 12:06:28 UTC
(In reply to Fernando Apesteguía from comment #2)

Thanks, I specifically marked the patch as being approved by me. Since the patch came from me I wasn't sure if that was needed.
Comment 4 Fernando Apesteguía freebsd_committer 2020-04-15 12:25:34 UTC
(In reply to Adam Jimerson from comment #3)

Thanks Adam,

It helps to so people don't have to look if maintainers approval is necessary :-)
Comment 5 Adam Jimerson 2020-04-15 12:29:23 UTC
Noted, thanks!

I'll keep this in mind in the future :-)
Comment 6 Adam Jimerson 2020-04-21 12:47:16 UTC
Comment on attachment 213362 [details]
Add optional py-jinja2-cli depends

This patch adds the wrong port, as jinja2-cli is not the same as j2cli.

https://pypi.org/project/jinja2-cli/ vs https://pypi.org/project/j2cli/

I have submitted a bug for the addition of the correct program at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245783