Bug 245617 - Mk/Uses/go.mk: Fix gomod-vendor-diff in cases when no empty line is returned in GH_TUPLE by modules2tuple
Summary: Mk/Uses/go.mk: Fix gomod-vendor-diff in cases when no empty line is returned ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitri Goutnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-14 12:33 UTC by Yuri Victorovich
Modified: 2020-04-14 12:53 UTC (History)
1 user (show)

See Also:


Attachments
patch (810 bytes, patch)
2020-04-14 12:33 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2020-04-14 12:33:44 UTC
Created attachment 213391 [details]
patch

'make gomod-vendor-diff' currently doesn't work properly when modules2tuple doesn't return the first empty line, when 3 or fewer items are in the GH_TUPLE list.
Comment 1 commit-hook freebsd_committer 2020-04-14 12:52:27 UTC
A commit references this bug:

Author: dmgk
Date: Tue Apr 14 12:52:03 UTC 2020
New revision: 531678
URL: https://svnweb.freebsd.org/changeset/ports/531678

Log:
  Mk/Uses/go.mk: Fix gomod-vendor-diff when there are 3 or fewer items in the GH_TUPLE

  'make gomod-vendor-diff' currently doesn't work properly when modules2tuple
  doesn't return the first empty line, when 3 or fewer items are in the GH_TUPLE
  list.

  PR:		245617
  Submitted by:	yuri

Changes:
  head/Mk/Uses/go.mk
Comment 2 Dmitri Goutnik freebsd_committer 2020-04-14 12:53:31 UTC
Committed, thanks for the fix!