Bug 245658 - sysutils/xen-guest-tools: clang 10: error: misleading indentation; statement is not part of the previous 'if'
Summary: sysutils/xen-guest-tools: clang 10: error: misleading indentation; statement ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-16 06:51 UTC by Trond.Endrestol
Modified: 2020-04-21 18:04 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback+


Attachments
Patch for tools/libxl/libxlu_disk_l.c (885 bytes, patch)
2020-04-16 06:52 UTC, Trond.Endrestol
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trond.Endrestol 2020-04-16 06:51:57 UTC
clang 10 complains and refuses to compile tools/libxl/libxlu_disk_l.c:

libxlu_disk_l.c:1256:13: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]
            if ( ! yyg->yy_state_buf )
            ^
libxlu_disk_l.c:1254:9: note: previous statement is here
        if ( ! yyg->yy_state_buf )
        ^
1 error generated.

The attached patch fixes the indentation and clang 10 is happy again.
Comment 1 Trond.Endrestol 2020-04-16 06:52:39 UTC
Created attachment 213453 [details]
Patch for tools/libxl/libxlu_disk_l.c
Comment 2 Dirk Meyer freebsd_committer 2020-04-16 20:32:39 UTC
I don't want to maintain style patches

I am testing on a different solution.
Comment 3 commit-hook freebsd_committer 2020-04-21 17:52:48 UTC
A commit references this bug:

Author: dinoex
Date: Tue Apr 21 17:52:37 UTC 2020
New revision: 532288
URL: https://svnweb.freebsd.org/changeset/ports/532288

Log:
  - fix build for CURRENT
  - speedup build
  PR:		245658

Changes:
  head/sysutils/xen-guest-tools/Makefile
  head/sysutils/xen-guest-tools/files/patch-tools-Makefile