Bug 245695 - multimedia/libv4l: update to 1.18.0 fails building
Summary: multimedia/libv4l: update to 1.18.0 fails building
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hans Petter Selasky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-17 13:16 UTC by Marco Beishuizen
Modified: 2020-04-17 14:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Beishuizen 2020-04-17 13:16:57 UTC
The update of multimedia/libv4l fails with an error:

[...]
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../.. -I../.. -I/usr/local/include -pthread -I../../lib/include -Wall -Wpointer-arith -D_GNU_SOURCE -I../../contrib/freebsd/include -I/usr/local/include -DLIBICONV_PLUG -O2 -pipe -march=nocona -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing -MT libdvbv5_la-crc32.lo -MD -MP -MF .deps/libdvbv5_la-crc32.Tpo -c crc32.c -o libdvbv5_la-crc32.o >/dev/null 2>&1
In file included from compat-soname.c:22:
../../lib/include/libdvbv5/dvb-dev.h:258:8: error: unknown type name
      'dvb_logfunc_priv'; did you mean 'dvb_logfunc'?
                     dvb_logfunc_priv logfunc, void *logpriv);
                     ^~~~~~~~~~~~~~~~
                     dvb_logfunc
/usr/local/include/libdvbv5/dvb-log.h:45:16: note: 'dvb_logfunc' declared here
typedef void (*dvb_logfunc)(int level, const char *fmt, ...) __attribute...
               ^
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../.. -I../.. -I/usr/local/include -pthread -I../../lib/include -Wall -Wpointer-arith -D_GNU_SOURCE -I../../contrib/freebsd/include -I/usr/local/include -DLIBICONV_PLUG -O2 -pipe -march=nocona -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing -MT libdvbv5_la-dvb-legacy-channel-format.lo -MD -MP -MF .deps/libdvbv5_la-dvb-legacy-channel-format.Tpo -c dvb-legacy-channel-format.c -o libdvbv5_la-dvb-legacy-channel-format.o >/dev/null 2>&1
1 error generated.
gmake[4]: *** [Makefile:944: libdvbv5_la-compat-soname.lo] Error 1
gmake[4]: *** Waiting for unfinished jobs....
mv -f .deps/libdvbv5_la-crc32.Tpo .deps/libdvbv5_la-crc32.Plo
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../.. -I../.. -I/usr/local/include -pthread -I../../lib/include -Wall -Wpointer-arith -D_GNU_SOURCE -I../../contrib/freebsd/include -I/usr/local/include -DLIBICONV_PLUG -O2 -pipe -march=nocona -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing -MT libdvbv5_la-countries.lo -MD -MP -MF .deps/libdvbv5_la-countries.Tpo -c countries.c -o libdvbv5_la-countries.o >/dev/null 2>&1
mv -f .deps/libdvbv5_la-dvb-legacy-channel-format.Tpo .deps/libdvbv5_la-dvb-legacy-channel-format.Plo
mv -f .deps/libdvbv5_la-countries.Tpo .deps/libdvbv5_la-countries.Plo
gmake[4]: Leaving directory '/usr/ports/multimedia/libv4l/work/v4l-utils-1.18.0/lib/libdvbv5'
gmake[3]: *** [Makefile:472: all-recursive] Error 1
gmake[3]: Leaving directory '/usr/ports/multimedia/libv4l/work/v4l-utils-1.18.0/lib'
gmake[2]: *** [Makefile:590: all-recursive] Error 1
gmake[2]: Leaving directory '/usr/ports/multimedia/libv4l/work/v4l-utils-1.18.0'
gmake[1]: *** [Makefile:517: all] Error 2
gmake[1]: Leaving directory '/usr/ports/multimedia/libv4l/work/v4l-utils-1.18.0'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1
[...]
Comment 1 Hans Petter Selasky freebsd_committer 2020-04-17 13:18:53 UTC
You need to deinstall libv4l first. The build it and it will work.

I'm sorry for the inconvenience.

It can probably be fixed in the port, but not trivially.

--HPS
Comment 2 Marco Beishuizen 2020-04-17 13:32:05 UTC
Deinstalling and reinstalling solved it.

Thanks!
Comment 3 commit-hook freebsd_committer 2020-04-17 14:06:18 UTC
A commit references this bug:

Author: hselasky
Date: Fri Apr 17 14:05:20 UTC 2020
New revision: 531931
URL: https://svnweb.freebsd.org/changeset/ports/531931

Log:
  Fix build when libv4l is already installed.
  Make sure we don't use any old header files installed in ${LOCALBASE}/include.

  PR:		245695
  Approved by:	pi (implicit)

Changes:
  head/multimedia/libv4l/Makefile
Comment 4 Hans Petter Selasky freebsd_committer 2020-04-17 14:06:31 UTC
Made a permanent fix.