Created attachment 213520 [details]
- Update to latest version
- Take maintainership from pool
Thank you for offering maintainership of a port Michael
For this and future issues, you'll want to QA (portlint and poudriere at least) prior to submission to pick-up issues early.
For more details and instructions, see:
We're also available in #freebsd-ports on the freenode IRC network if you need help, support or just to hang out and learn.
See Also the following "Resources" to level up ports contributions:
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/137401428
Thanks for the fast response, and sorry for the lack of information here.
I already do this prior uploading a patch.
Portlint is happy and I'll upload build logs for amd64 and i386.
root@build:/usr/ports/audio/fapg-new # portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 2 warnings found.
Created attachment 213524 [details]
Created attachment 213525 [details]
(In reply to Michael Muenz from comment #3)
Great to know Michael, thanks for following up
It's helpful to explicitly mention that QA passes, and logs arent necessary. Just add something like the following to the initial description/comment:
portlint: OK (looks fine.)
testport: OK (poudriere: <versions>, <archs>, <OPTIONS> tested)
If the port has a test target to run a test suite, add:
maketest: OK (XXX of YYY tests PASS)
Comment on attachment 213520 [details]
Approved by: portmgr (unmaintained port)
Thanks, good to know!
Usually I also run "make clean && make && make stage-qa && make package" when there a no dependency breakers. But with your recent comment I saw that I have to use:
make clean && make && make stage-qa DEVELOPER=yes && make package
So, also no regressions for this patch too :)
Love this community!
A commit references this bug:
Date: Sun Apr 19 20:06:03 UTC 2020
New revision: 532157
audio/fapg: Update to 0.43
- Pass maintainership to the submitter
Submitted by: Michael Muenz <email@example.com>
Committed, thanks for taking over maintainership!