Bug 245717 - audio/fapg: Update to 0.43, Take MAINTAINER'ship
Summary: audio/fapg: Update to 0.43, Take MAINTAINER'ship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitri Goutnik
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-04-18 05:05 UTC by Michael Muenz
Modified: 2020-04-19 20:09 UTC (History)
2 users (show)

See Also:


Attachments
fapg 0.43 (944 bytes, patch)
2020-04-18 05:05 UTC, Michael Muenz
koobs: maintainer-approval+
Details | Diff
buildlog-12.1amd64 (14.41 KB, text/plain)
2020-04-18 05:47 UTC, Michael Muenz
no flags Details
buildlog-12.1i386 (14.47 KB, text/plain)
2020-04-18 05:48 UTC, Michael Muenz
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Muenz 2020-04-18 05:05:40 UTC
Created attachment 213520 [details]
fapg 0.43

- Update to latest version
- Take maintainership from pool
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-04-18 05:10:38 UTC
Thank you for offering maintainership of a port Michael

For this and future issues, you'll want to QA (portlint and poudriere at least) prior to submission to pick-up issues early.

For more details and instructions, see: 

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-testing.html

We're also available in #freebsd-ports on the freenode IRC network if you need help, support or just to hang out and learn.

See Also the following "Resources" to level up ports contributions:

  https://wiki.freebsd.org/Bugzilla/
Comment 2 Automation User 2020-04-18 05:20:17 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/137401428
Comment 3 Michael Muenz 2020-04-18 05:46:56 UTC
Hi Kubilay,

Thanks for the fast response, and sorry for the lack of information here. 
I already do this prior uploading a patch. 

Portlint is happy and I'll upload build logs for amd64 and i386. 

root@build:/usr/ports/audio/fapg-new # portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 2 warnings found.
Comment 4 Michael Muenz 2020-04-18 05:47:54 UTC
Created attachment 213524 [details]
buildlog-12.1amd64
Comment 5 Michael Muenz 2020-04-18 05:48:24 UTC
Created attachment 213525 [details]
buildlog-12.1i386
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2020-04-18 05:50:40 UTC
(In reply to Michael Muenz from comment #3)

Great to know Michael, thanks for following up

It's helpful to explicitly mention that QA passes, and logs arent necessary. Just add something like the following to the initial description/comment:

QA:

portlint: OK (looks fine.)
testport: OK (poudriere: <versions>, <archs>, <OPTIONS> tested)

If the port has a test target to run a test suite, add:

maketest: OK (XXX of YYY tests PASS)
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2020-04-18 05:51:06 UTC
Comment on attachment 213520 [details]
fapg 0.43

Approved by: portmgr (unmaintained port)
Comment 8 Michael Muenz 2020-04-18 05:56:19 UTC
Thanks, good to know! 
Usually I also run "make clean && make && make stage-qa && make package" when there a no dependency breakers. But with your recent comment I saw that I have to use:

 make clean && make && make stage-qa DEVELOPER=yes && make package


So, also no regressions for this patch too :)

Love this community!
Comment 9 commit-hook freebsd_committer 2020-04-19 20:06:06 UTC
A commit references this bug:

Author: dmgk
Date: Sun Apr 19 20:06:03 UTC 2020
New revision: 532157
URL: https://svnweb.freebsd.org/changeset/ports/532157

Log:
  audio/fapg: Update to 0.43

  - Pass maintainership to the submitter

  PR:		245717
  Submitted by:	Michael Muenz <m.muenz@gmail.com>

Changes:
  head/audio/fapg/Makefile
  head/audio/fapg/distinfo
Comment 10 Dmitri Goutnik freebsd_committer 2020-04-19 20:09:18 UTC
Committed, thanks for taking over maintainership!