Created attachment 213558 [details] shar containing resurrected py-mcomix py-mcomix was recently retired with "Old, uses EOLed python27". This is an update to a python3 fork from <https://github.com/multiSnow/mcomix3>. Debian testing also switched to this fork. The Makefile still contains the old maintainer (ashish@FreeBSD.org), not sure what's the policy for resurrecting ports.
Thank you for restoring a port Stefan. It would be great if you could provide a unified diff (svn diff or diff -u) against the last revision of the port, according to the following: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-re-adding If you'd like to maintain the port, please update the patch accordingly. ^Triage: CC previous maintainer for feedback
Created attachment 213608 [details] diff against py-mcomix r527560
Added patch against revision 527560 instead of shar. ashish can keep the port if he wants to. But set me (shoesoft@gmx.net) as new maintainer, if it would be reset to ports@ otherwise.
(In reply to Stefan Ehmann from comment #3) Thanks for working on this. I'll test it, and commit it (if no issues), assigning maintainership to you.
(In reply to Stefan Ehmann from comment #3) Couple of issues: - plist is missing in the diff. I have used the one from shar, and seems to be okay. - version number in repository is 1.3.0dev0, whereas port has 1.2.1g20200418. Could you update it ? Could you please provide an updated diff, which I will then commit, if no other problem is encountered in testing. Thanks!
About the version: 1.3.dev0 was set by the old authors in 2016, shortly after the release of 1.2.1. I guess it's just a placeholder, probably there will never be a 1.3.0 release. Debian testing (<https://packages.debian.org/bullseye/mcomix>) uses 1.2.1mcomix3+git20200206-1 as version. That's why I am using 1.2.1 as base version. I think 1.3.0dev0 (without suffix) would be wrong. Development is still going on, but I guess there will be no release in the near future. There will be port updates, but upstream version will stay at 1.3.0dev0. We could use 1.3.0dev0g20200418 but that's not very pretty. Another approach is to patch VERSION in constants.py so that the about dialog is consistent with the port version. Sorry, the version explanation got longer than expected. Please state your preferred solution and I'll update the diff with fixed version and plist.
(In reply to Stefan Ehmann from comment #6) In that case patching VERSION to be consistent would be good. If you're okay with maintaining the port, then please include the MAINTAINER in Makefile change in the new diff too. Thanks!
Created attachment 213702 [details] revised patch against py-mcomix r527560 Updated patch fixes these issues: * set VERSION in constants.py to PORTVERSION (shown in about dialog) * add missing pkg-plist * update maintainer
A commit references this bug: Author: ashish Date: Thu Apr 23 10:54:33 UTC 2020 New revision: 532665 URL: https://svnweb.freebsd.org/changeset/ports/532665 Log: - Resurrect port - Switch to new upstream Python3 fork at GitHub[1] - Remove patches not applicable anymore[1] - Transfer maintainership to submitter[1] - Update version in the port source so as to be consistent[1] - Depend on Python 3.7+ as it's a Python 3 fork PR: 245738 Submitted by: Stefan Ehmann <shoesoft@gmx.net>[1] Changes: head/MOVED head/graphics/Makefile head/graphics/py-mcomix/ head/graphics/py-mcomix/Makefile head/graphics/py-mcomix/distinfo head/graphics/py-mcomix/files/ head/graphics/py-mcomix/pkg-descr head/graphics/py-mcomix/pkg-plist
Committed with minor changes related to portlint, and dependency on Python 3.7+. Thanks!