Created attachment 213613 [details] The updated port Please update `games/alephone` to a new version. The new port is attached
Hi Shamaz, Thanks for the update. It is much preferred to attach a diff file[1] (svn diff the best) to request port updates. shar files are preferred when we want to add a new port. Would you mind attaching a diff file? [1] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#svn-diff
Created attachment 213634 [details] Diff for games/alephone
Done. A question for the future: will diff between commits produced by `git diff` or `git show` be OK? I feel very uncomfortable using SVN.
(In reply to shamaz.mazum from comment #3) Thanks for that. As per the current documentation, svn diff is the preferred option, probably because the official ports repository is in subversion :) That said, people commit changes coming from git too.
Created attachment 213667 [details] Diff for games/alephone Updated the diff. Fix somehow misspelled FFMPEG. Also added missing dependencies (used `poudriere testport` to find them). Support for smpeg is removed because smpeg2 has incompatible API changes.
Created attachment 213670 [details] additional improvements on top of submitter's patch This port has a number of issues. Some of them you already fixed, but there are issues in pkg-plist as well (PORTDOCS = * means we don't have to include those files in pkg-plist for example), missing USES, patches format, etc. I fixed most of them in the attached patch. Please, review it. Additionally, I installed games/alephone-{data,scenarios} but when running alephone, it complains about not finding maps, sounds, etc... You might be interested in using ports-mgmt/portlint and ports-mgmt/poudriere. These tools catch most if not all of the common pitfalls we face when updating ports. You can have more information here: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#testing-poudriere https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-portlint Thanks!
Thanks for the work, I must use poudriere before sending anything. Sorry, I'm still a newbie in porting. Check the updated patch (tested it with `poudriere testport`): See https://bugs.freebsd.org/bugzilla/attachment.cgi?id=213667 Turns out smpeg2 has API changes and is incompatible with smpeg, and smpeg is what alephone really wants to. Fortunately, it's not even used when compiling with ffmpeg. I removed support for smpeg, as it depends on old SDL, which is Wayland-incompatible (I am a Wayland user).
(In reply to shamaz.mazum from comment #7) It's OK. Thanks for the patch, but there is no rush here. Please, review my patch and add my changes to yours (or the other way around). There are still some missing pieces like USE=shame-mime-info and these portlint issues: portlint -AC WARN: Makefile: COMMENT is not supposed to begin with 'A ', 'An ', or 'The '. WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. FATAL: Makefile: extra item "LICENSE" placed in the MAINTAINER section. FATAL: Makefile: extra item "LIB_DEPENDS" placed in the LICENSE section. 2 fatal errors and 2 warnings found. Thanks
Created attachment 213674 [details] Merged my patch with Fernando Apesteguía's Added a new patch (merged your and mine). portlint and poudriere seems to be happy
Also I do not know if `# $FreeBSD$` line needs to be modified. I followed this instruction: > [the header...just to make it easier for us to identify the ports.] > # $FreeBSD$ > [ ^^^^^^^^^ This will be automatically replaced with RCS ID string by SVN > when it is committed to our repository. If upgrading a port, do not alter > this line back to "$FreeBSD$". SVN deals with it automatically.] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-samplem portlint with no options does not complain about this, but portlint -AC does: > WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. I understand it as mutually exclusive recommendations. I hope you'll help me if there is something wrong with the patch.
(In reply to shamaz.mazum from comment #10) They're OK, don't worry. The port is queued for build testing in the last arcitechture/OS version. I'll come back to you when it's done.
Build and run testing OK. I'll give a couple of days more for maintainer to show up. Thanks!
A commit references this bug: Author: fernape Date: Sun Apr 26 16:57:52 UTC 2020 New revision: 533079 URL: https://svnweb.freebsd.org/changeset/ports/533079 Log: games/alephone: Update to 20190331 * Add license * Fix COMMENT * Add missing dependencies PR: 245771 Submitted by: shamaz.mazum@gmail.com Approved by: fiziologus@gmail.com (maintainer timeout) Changes: head/games/alephone/Makefile head/games/alephone/distinfo head/games/alephone/pkg-plist
Committed, Thanks!
Thanks to you!