Bug 245882 - [PATCH] x11-drivers/xorg-drivers: make more user friendly options
Summary: [PATCH] x11-drivers/xorg-drivers: make more user friendly options
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-24 15:37 UTC by rozhuk.im
Modified: 2020-09-17 09:37 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Attachments
patch (1.50 KB, patch)
2020-04-24 15:37 UTC, rozhuk.im
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rozhuk.im 2020-04-24 15:37:46 UTC
Created attachment 213755 [details]
patch

Make options desctiptions user friendly - extract ports COMMENT.

┌──────────────────────────── xorg-drivers-7.7_6 ──────────────────────────────┐
│ ┌──────────────────────────────────────────────────────────────────────────┐ │  
│ │────────────────────────────────── INPUT ─────────────────────────────────│ │  
│ │ [ ] EGALAX         eGalax touch screen input driver for X.Org            │ │  
│ │ [ ] ELOGRAPHICS    X.Org elographics input driver                        │ │  
│ │ [ ] EVDEV          X.Org event device input driver                       │ │  
│ │ [ ] JOYSTICK       X.Org joystick input driver                           │ │  
│ │ [x] KEYBOARD       X.Org keyboard input driver                           │ │  
│ │ [x] LIBINPUT       X.Org libinput input driver                           │ │  
│ │ [x] MOUSE          X.Org mouse input driver                              │ │  
│ │ [ ] SYNAPTICS      X.Org synaptics input driver                          │ │  
│ │ [ ] VMMOUSE        X.Org vmmouse input driver                            │ │  
│ │ [ ] VOID           X.Org void input driver                               │ │  
│ │ [ ] WACOM          X.Org legacy Wacom tablet driver                      │ │  
│ │────────────────────────────── Video support ─────────────────────────────│ │  
│ │ [ ] AMDGPU         X.Org amdgpu display driver                           │ │  
│ │ [ ] APM            X.Org apm display driver                              │ │  
│ └─────┴(+)─────────────────────────────────────────────────────────34%─────┘ │  
├──────────────────────────────────────────────────────────────────────────────┤  
│                       <  OK  >            <Cancel>                           │  
└──────────────────────────────────────────────────────────────────────────────┘
Comment 1 Niclas Zeising freebsd_committer 2020-04-24 20:23:40 UTC
I'm not sure it's a good idea to run make several times just to get the ports comments.
Comment 2 rozhuk.im 2020-04-24 20:40:19 UTC
(In reply to Niclas Zeising from comment #1)

Original "Install xxxx yyyy driver" in many cases mean nothing untill xxxxx googled.

To reduce CPU usage it is possible to make "config-opts" target that will be only called before options show to user and move all code that generates options description to it.
Comment 3 Niclas Zeising freebsd_committer 2020-09-17 09:37:42 UTC
I don't like this, as I've stated earlier.  Running make in a loop just to get descriptions for the list feels both error prone and can be resource intensive.
Closing this.

Plus, in this case you rarely need to stray from the defaults, I think.