Bug 245959 - www/iridium: Update to 2020.04.81
Summary: www/iridium: Update to 2020.04.81
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-chromium mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-27 08:54 UTC by Matthias Wolf
Modified: 2020-05-25 16:26 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (chromium)


Attachments
www/iridium (230.05 KB, application/gzip)
2020-04-27 08:56 UTC, Matthias Wolf
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Wolf 2020-04-27 08:54:24 UTC
Update www/iridium to 2020.04.81

portlint -AC: ok
poudriere testport: ok on 12.1/amd64, 12.1/i386 and 11.3/amd64

(see https://poudriere.rheinwolf.de/builds/20200424-08:11:24.53501/ for results)
Comment 1 Matthias Wolf 2020-04-27 08:56:26 UTC
Created attachment 213839 [details]
www/iridium

update - gzipped due to file size limit
Comment 2 Chris Hutchinson 2020-05-14 16:38:59 UTC
(In reply to Matthias Wolf from comment #1)
Line 4723 of your diff reads:

The profile appears to be in use by another browsr process...

shouldn't that read:

The profile appears to be in use by another browser process?

If the word "browser: is spelled correctly, this line need
never have been changed/added

Just thought I'd ask.

Thanks!

--Chris
Comment 3 Matthias Wolf 2020-05-18 13:58:33 UTC
(In reply to Chris Hutchinson from comment #2)
The typo is in the upstream source already, the patch changes the is_linux condition to is_posix (to make those resource strings available in the FreeBSD build).
Comment 4 Chris Hutchinson 2020-05-19 18:03:30 UTC
(In reply to Matthias Wolf from comment #3)
Ah. So in order to be POSIX compliant. One must spell
browser browsr

@@ -7,9 +16,9 @@
 -      <if expr="is_linux or is_macosx">
 +      <if expr="is_linux or is_macosx or is_posix">
          <message name="IDS_PROFILE_IN_USE_POSIX" desc="Message shown when the browser cannot start because the profile is in use on a different host.">
-           The profile appears to be in use by another browser process
...
+           The profile appears to be in use by another browsr process
...


;-)
Comment 5 Matthias Wolf 2020-05-25 09:54:55 UTC
(In reply to Chris Hutchinson from comment #4)
Ah, I think the confusion stems from the attachment being patches for patch files.

In the upstream source the typo is present in the current version, but wasn't in the older version, so that line changes (as it is included as context for the patch file).

If applied, the patch in the files/ dir looks like:

@@ -750,7 +750,7 @@ The browser is unable to recover your settings.
       </message>
 
       <!-- ProcessSingleton -->
-      <if expr="is_linux or is_macosx">
+      <if expr="is_linux or is_macosx or is_posix">
         <message name="IDS_PROFILE_IN_USE_POSIX" desc="Message shown when the browser cannot start because the profile is in use on a different host.">
           The profile appears to be in use by another browsr process (<ph name="PROCESS_ID">$1<ex>12345</ex></ph>) on another computer (<ph name="HOST_NAME">$2<ex>example.com</ex></ph>). The browser has locked the profile so that it doesn't get corrupted. If you are sure no other processes are using this profile, you can unlock the profile and relaunch the browser.
         </message>
Comment 6 Chris Hutchinson 2020-05-25 16:26:46 UTC
(In reply to Matthias Wolf from comment #5)
Thanks for the reply, Matthias. You're probably right.
I went ahead and applied your patch. Then built &&
installed iridium on FBSD13 13.0-CURRENT r361107 amd64.
With ports @r535355, and all went as intended/expected.
IOW As far as 13-CURRENT on amd64 goes, this patch is
ready for commit. It runs just fine.

Thanks!

--Chris