Bug 246034 - mail/phplist update to 3.5.4
Summary: mail/phplist update to 3.5.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-04-29 21:49 UTC by Krzysztof
Modified: 2020-07-05 17:03 UTC (History)
2 users (show)

See Also:


Attachments
update phplist to 3.5.3 (15.71 KB, patch)
2020-04-29 21:49 UTC, Krzysztof
ports: maintainer-approval+
Details | Diff
log from build (39.20 KB, text/plain)
2020-04-29 21:51 UTC, Krzysztof
no flags Details
phplist-update-3.5.4 (31.16 KB, patch)
2020-06-13 06:08 UTC, Krzysztof
ports: maintainer-approval+
Details | Diff
poudriere log for phplist .3.5.4 (40.17 KB, text/plain)
2020-06-13 06:10 UTC, Krzysztof
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof 2020-04-29 21:49:58 UTC
Created attachment 213921 [details]
update phplist to 3.5.3

There is new version of mail/phplist. I'm attaching patch which updates port and log from poudriere.
Comment 1 Krzysztof 2020-04-29 21:51:08 UTC
Created attachment 213922 [details]
log from build
Comment 2 Tobias C. Berner freebsd_committer 2020-04-30 18:56:58 UTC
Moin moin 

I see you added an NLS option, but don't see any impact on the plsit. 
Is that intended?

mfg Tobias
Comment 3 Krzysztof 2020-04-30 20:23:39 UTC
So...

I've made portlint -A and I added NLS option according to portlint's suggestion (use of PHP=gettext).

But AFAIK translations of phplsit are stored in database, so maybe NLS is not needed in this case. But gettext is needed (according to phplist documentation - https://resources.phplist.com/system/start)

So I'm open for any suggestion :-)))
Comment 4 Torsten Zuehlsdorff freebsd_committer 2020-05-02 16:41:51 UTC
I think  in this case you should add gettext to the USE_PHP line, since the PHP module gettext is used. Or am i wrong?
Comment 5 Krzysztof 2020-05-06 15:20:09 UTC
OK,

I refreshed my memory :-))) phplist is installing helpfiles in many languages (the are located lists/admin/help/__lang__/*.php

So as I inderstand I should add NLS knob to use gettext-runtime and eventually php-gettext. Also I should add:

%%NLS%%%%WWWDIR%%/lists/admin/help/es/format.php

in pkg-plist. (this is an example)

Am I correct?
Comment 6 Automation User 2020-05-10 15:24:07 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/144520713
Comment 7 Krzysztof 2020-06-13 06:08:42 UTC
Created attachment 215512 [details]
phplist-update-3.5.4

Meanwhile there is new version of phplist (3.5.4) So this patch include this update. Also I removed NLS knob as not needed.

I hoipe phplist will be updated soon :-)))
Comment 8 Krzysztof 2020-06-13 06:10:05 UTC
Created attachment 215513 [details]
poudriere log for phplist .3.5.4

Also I'm attaching logfile from my poudriere
Comment 9 commit-hook freebsd_committer 2020-06-13 08:35:18 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jun 13 08:34:19 UTC 2020
New revision: 538652
URL: https://svnweb.freebsd.org/changeset/ports/538652

Log:
  mail/phplist update to 3.5.4

  PR:		246034
  Submitted by:	Krzysztof <ports@bsdserwis.com>

Changes:
  head/mail/phplist/Makefile
  head/mail/phplist/distinfo
  head/mail/phplist/pkg-plist
Comment 10 Tobias C. Berner freebsd_committer 2020-07-05 17:03:18 UTC
I seem to have forgotten to close this one :)