Bug 246074 - print/cups-filters: cups-browsed.conf is overwritten on installation/update
Summary: print/cups-filters: cups-browsed.conf is overwritten on installation/update
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-05-01 07:44 UTC by Felix Palmen
Modified: 2020-05-21 15:27 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (tijl)


Attachments
Install cups-browsed.conf with @sample mechanism (2.93 KB, patch)
2020-05-01 07:44 UTC, Felix Palmen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Palmen 2020-05-01 07:44:45 UTC
Created attachment 213971 [details]
Install cups-browsed.conf with @sample mechanism

My clients need a specific BrowsePoll setting in cups-browsed.conf because the print server resides in a different subnet. As the port overwrites this config on each update, I have to redo it regularly.

Suggesting attached patch using the @sample mechanism for cups-browsed.conf. For Makefile, only the last hook is the *actual* change, the others are whitespace changes needed to silence portlint during poudriere testport.
Comment 1 Automation User 2020-05-16 00:12:07 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/146600702
Comment 2 Felix Palmen 2020-05-20 20:05:02 UTC
Hello Tijl, sorry for nagging, I'd just love to get some feedback. This patch would solve my actual problem, but if there are any issues with it, please let me know, thanks!
BR, Felix
Comment 3 Tijl Coosemans freebsd_committer 2020-05-21 10:34:21 UTC
Except for the white space changes the patch is fine.  When the first tab on a line is just a single space wide I sometimes replace it with an actual space because then diffs are less messed up.

I planned to include the patch in the next version update.  Upstream tends to release quite often.  It's just taken unusually long right now.
Comment 4 Felix Palmen 2020-05-21 15:27:52 UTC
Hello Tijl, thanks a lot for the feedback! As for the whitespace, I only changed it because portlint insists on tabs, should be easy enough to skip these changes if you don't like them :)
I was just worried there's either something wrong with the patch or the PR went unnoticed in a bursting inbox ;) So thanks for letting me know, of course it makes sense here to await a new version, as this change won't have any benefit before.
BR, Felix