Bug 246092 - devel/llvm90: make ELFv2 default if --target doesn't contain OS version
Summary: devel/llvm90: make ELFv2 default if --target doesn't contain OS version
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-05-01 12:56 UTC by Jan Beich
Modified: 2023-07-11 22:43 UTC (History)
1 user (show)

See Also:
brooks: maintainer-feedback+


Attachments
v1 (1.68 KB, patch)
2020-05-01 12:57 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2020-05-01 12:56:04 UTC
Similar to ports r531783 but for libclang.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2020-05-01 12:57:14 UTC
Created attachment 213994 [details]
v1
Comment 2 Jan Beich freebsd_committer freebsd_triage 2020-05-01 13:10:19 UTC
Comment on attachment 213994 [details]
v1

> ++      if (TT.getOSMajorVersion() == 0 || TT.getOSMajorVersion() >= 13)

Alternatively, target ELF version can be derived from host (on powerpc64) via _CALL_ELF predefined macro.
Comment 3 Brooks Davis freebsd_committer freebsd_triage 2020-05-01 17:06:44 UTC
LGTM, feel free to commit or I'll get around it eventually
Comment 4 Brooks Davis freebsd_committer freebsd_triage 2023-07-11 22:43:20 UTC
We've long since stopped using llvm90 and ELFv2 support is in versions we do use.