Bug 246099 - login.conf documents passwordtime as unimplemented in base
Summary: login.conf documents passwordtime as unimplemented in base
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-01 17:07 UTC by Andriy Gapon
Modified: 2021-10-15 13:17 UTC (History)
4 users (show)

See Also:


Attachments
login.conf.5 patch (986 bytes, patch)
2021-09-30 05:59 UTC, Felix Johnson
felix.the.red: maintainer-approval? (felix.the.red)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Gapon freebsd_committer freebsd_triage 2020-05-01 17:07:43 UTC
login.conf puts passwordtime in RESERVED CAPABILITIES section that has this preamble:
     The following capabilities are reserved for the purposes indicated and
     may be supported by third-party software.  They are not implemented in
     the base system.

But in fact it looks that passwordtime is implemented in the base for several years now.
Comment 1 Conrad Meyer freebsd_committer freebsd_triage 2020-05-01 17:42:36 UTC
Maybe this is a case where we can fix the code to match the documentation.
Comment 2 Andriy Gapon freebsd_committer freebsd_triage 2020-05-01 17:44:32 UTC
(In reply to Conrad Meyer from comment #1)
Do you really mean removing support for passwordtime from FreeBSD? :-)
Comment 3 Felix Johnson freebsd_triage 2021-09-30 05:59:43 UTC
Created attachment 228273 [details]
login.conf.5 patch

Move passwordtime from RESERVED CAPABILITIES to AUTHENTICATION.
This has been supported since 2010, see bug 93473.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-10-06 20:53:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=e7f8f3b95e1ff76765f1d2f4412b95f6ff5abe25

commit e7f8f3b95e1ff76765f1d2f4412b95f6ff5abe25
Author:     Felix Johnson <felix.the.red@gmail.com>
AuthorDate: 2021-10-06 20:47:02 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2021-10-06 20:51:22 +0000

    login.conf.5: Mark passwordtime as implemented

    login.conf.5 listed passwordtime in RESERVED CAPABILITIES, which is a
    section for capabilities not implemented in the base system. However,
    passwordtime has been implemented in the base for several years now.

    PR:             246099
    Reported by:    avg
    Reviewed by:    0mp
    MFC after:      3 days

 lib/libutil/login.conf.5 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 5 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-10-06 20:53:50 UTC
Thanks for the patch!
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-10-15 13:16:17 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a9077f3e0c11a878bd4a8a729e1e9c3147c135e5

commit a9077f3e0c11a878bd4a8a729e1e9c3147c135e5
Author:     Felix Johnson <felix.the.red@gmail.com>
AuthorDate: 2021-10-06 20:47:02 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2021-10-15 13:14:53 +0000

    login.conf.5: Mark passwordtime as implemented

    login.conf.5 listed passwordtime in RESERVED CAPABILITIES, which is a
    section for capabilities not implemented in the base system. However,
    passwordtime has been implemented in the base for several years now.

    PR:             246099
    Reported by:    avg
    Reviewed by:    0mp
    MFC after:      3 days

    (cherry picked from commit e7f8f3b95e1ff76765f1d2f4412b95f6ff5abe25)

 lib/libutil/login.conf.5 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-10-15 13:17:18 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=75bb69738e427fd34fe2695d71b5381c2cc35066

commit 75bb69738e427fd34fe2695d71b5381c2cc35066
Author:     Felix Johnson <felix.the.red@gmail.com>
AuthorDate: 2021-10-06 20:47:02 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2021-10-15 13:16:00 +0000

    login.conf.5: Mark passwordtime as implemented

    login.conf.5 listed passwordtime in RESERVED CAPABILITIES, which is a
    section for capabilities not implemented in the base system. However,
    passwordtime has been implemented in the base for several years now.

    PR:             246099
    Reported by:    avg
    Reviewed by:    0mp
    MFC after:      3 days

    (cherry picked from commit e7f8f3b95e1ff76765f1d2f4412b95f6ff5abe25)

 lib/libutil/login.conf.5 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)