Bug 246116 - sysutils/memtest86+: update to 5.31b
Summary: sysutils/memtest86+: update to 5.31b
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://www.memtest.org/#change
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-02 07:59 UTC by Alessandro Sagratini
Modified: 2020-05-06 06:44 UTC (History)
3 users (show)

See Also:
fernape: maintainer-feedback? (avg)


Attachments
update of memtest86+ to 5.31b (4.94 KB, patch)
2020-05-02 07:59 UTC, Alessandro Sagratini
no flags Details | Diff
additional improvements on top of submitter's patch (4.70 KB, patch)
2020-05-06 05:38 UTC, Fernando Apesteguía
fernape: maintainer-approval? (avg)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Sagratini 2020-05-02 07:59:43 UTC
Created attachment 214020 [details]
update of memtest86+ to 5.31b

update of memtest86+ to 5.31b version, release a couple of months back. updated gcc dependency from 4.8 to 9

please let me know if you have any doubts or concerns
Comment 1 Nuno Teixeira 2020-05-03 15:58:56 UTC
PR sent to wrong port.

This is memtest86, not memtest86+

Thanks,

Nuno
Comment 2 Alessandro Sagratini 2020-05-03 16:42:55 UTC
I'm not sure about your "no" feedback: isn't this patch referring to latest version from www.memtest.org, which is what *existing* memtest86+ port uses? 

Let me know if there's anything else you need from me.
Comment 3 Nuno Teixeira 2020-05-03 17:47:27 UTC
(In reply to Alessandro Sagratini from comment #2)

You are assigning PRs to sysutils/memtest86 and it should be sysutils/memtest86+

memtest86 its just a ISO
Comment 4 Alessandro Sagratini 2020-05-03 18:03:54 UTC
Oh, you are correct, I am not sure why maintainer feedback was assigned to you, I am going to see if I can change that on my own, otherwise, some developer can do that, hopefully :)
Comment 5 Fernando Apesteguía freebsd_committer 2020-05-04 06:59:48 UTC
Assigning proper maintainer address in maintainer-feedback.
Comment 6 Andriy Gapon freebsd_committer 2020-05-05 11:27:04 UTC
If the port builds and works then I do not have any objections.
I am a bit out of time to test it myself, so could anyone please confirm this?
It might be a good idea to advertise this update on ports@ and maybe hackers@.
Thanks!
Comment 7 Fernando Apesteguía freebsd_committer 2020-05-06 05:38:11 UTC
Created attachment 214186 [details]
additional improvements on top of submitter's patch

Thanks for the original patch. I made a few changes on top of it:

* Reorder ONLY_FOR_ARCHS
* USE_GCC= 9+ since it builds and this way we could benefit of future compiler improvementes (or go back to just 9 if something breaks)
* Remake patches to comply with the ports standard.

Additionally, when I tried to test this from boot loader, this is what I got:

OK unload
OK load /boot/opt/memtest86+
don't know how to load module '/boot/opt/memtest86+'

Same thing happens with current version (5.01). Any ideas?
Comment 8 Fernando Apesteguía freebsd_committer 2020-05-06 05:41:20 UTC
The port builds fine in {11.3,12.1}{amd64,i386} and 13-current amd64.
Comment 9 Andriy Gapon freebsd_committer 2020-05-06 06:43:46 UTC
In reply to Fernando Apesteguía from comment #8)
Thank you!
I see this on the memtest86+ page:
> Here is Memtest86+ 5.31b, with many bug fixes in the core functions.
> This build is not ready for production yet, because it lacks some feedbacks from beta-testers.
Maybe we should wait until the new version is out of beta?
Or, perhaps, create a new port for the devel version?
Comment 10 Andriy Gapon freebsd_committer 2020-05-06 06:44:45 UTC
(In reply to Fernando Apesteguía from comment #7)
It's been a while since I last started memtest86+ from loader.
Maybe something in loader changed.
Let me look into it.