Bug 246124 - [NEW PORT] games/libretro-yabause: Yabause - Sega Saturn Emulator
Summary: [NEW PORT] games/libretro-yabause: Yabause - Sega Saturn Emulator
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Loïc Bartoletti
URL: https://github.com/libretro/yabause
Depends on:
Reported: 2020-05-02 13:55 UTC by Daniel Menelkir
Modified: 2020-06-01 07:50 UTC (History)
2 users (show)

See Also:
menelkir: maintainer-feedback+

libretro-yabause.diff (4.39 KB, patch)
2020-05-02 13:55 UTC, Daniel Menelkir
menelkir: maintainer-approval+
Details | Diff
libretro-yabause-v2.diff (4.41 KB, patch)
2020-05-05 23:19 UTC, Daniel Menelkir
no flags Details | Diff
libretro-yabause-v3.diff (4.40 KB, patch)
2020-05-08 07:00 UTC, Daniel Menelkir
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Menelkir 2020-05-02 13:55:08 UTC
Created attachment 214031 [details]

Yabause is a Sega Saturn emulator core for libretro compatible emulators, such as retroarch.
Comment 1 Daniel Menelkir 2020-05-05 23:19:57 UTC
Created attachment 214182 [details]

Changed the PORTVERSION and do-install to match bug #246067
Comment 2 Daniel Menelkir 2020-05-08 07:00:41 UTC
Created attachment 214264 [details]

Removed ${COREDIR} variable.
Comment 3 Loïc Bartoletti freebsd_committer 2020-05-08 07:05:43 UTC
This port requires gcc-c++11-lib on i386. I'm trying with aarch64.
Comment 4 Loïc Bartoletti freebsd_committer 2020-05-17 06:27:33 UTC
I see there is a CMakeFiles provideded with yabause. Is there any reason to not use it?
Comment 5 Daniel Menelkir 2020-05-17 08:59:55 UTC
(In reply to Loïc Bartoletti from comment #4)

Some ports (if not most of them) are just the emulator adapted to run as a libretro core, so it shouldn't be compile as a standalone emulator, instead, they should be compiled used the provided libretro "adapter". In case of the yabause, the "adapter" is located at src/libretro.

For reference, libretro developers provide a libretro-super repository that you can try to compile all cores as-is, so I use it as a base for the ports because it shows me where to start: https://github.com/libretro/libretro-super/blob/master/recipes/linux/cores-linux-x64-generic.

So it's the line for yabause: yabause libretro-yabause https://github.com/libretro/yabause.git master YES GENERIC Makefile yabause/src/libretro
Comment 6 Loïc Bartoletti freebsd_committer 2020-05-21 06:00:33 UTC
(In reply to Daniel Menelkir from comment #5)
OK, and libretro doesn't have cmake but a classical Makefile. I made a tiny change to build on arm and i386 platforms.
Comment 7 Daniel Menelkir 2020-05-21 10:58:37 UTC
(In reply to Loïc Bartoletti from comment #6)

Thanks. I have a struggle (hardware related) to have multiple archs to test. This kind of changes are always welcome.
Comment 8 Loïc Bartoletti freebsd_committer 2020-05-22 06:29:02 UTC
(In reply to Daniel Menelkir from comment #7)
Maybe you don't know, but you can try your ports with Poudriere https://www.freebsd.org/doc/handbook/ports-poudriere.html
Comment 9 Daniel Menelkir 2020-05-22 11:01:02 UTC
(In reply to Loïc Bartoletti from comment #8)

I know, I just don't have disk space yet. :D
Comment 10 commit-hook freebsd_committer 2020-06-01 07:49:49 UTC
A commit references this bug:

Author: lbartoletti
Date: Mon Jun  1 07:49:42 UTC 2020
New revision: 537463
URL: https://svnweb.freebsd.org/changeset/ports/537463

  [NEW PORT] games/libretro-yabause: Yabause - Sega Saturn Emulator

  PR:		246124
  Submitted by:	menelkir@itroll.org
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D24940

Comment 11 Loïc Bartoletti freebsd_committer 2020-06-01 07:50:14 UTC
Committed, thanks!