Bug 246199 - devel/vulkan-tools: build breaks if vulkan-loader is installed with Wayland support only
Summary: devel/vulkan-tools: build breaks if vulkan-loader is installed with Wayland s...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL: https://reviews.freebsd.org/D24833
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-04 23:40 UTC by Lorenzo Salvadore
Modified: 2020-06-11 19:14 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (val)

Attachments
vulkan-tools log (9.05 KB, text/plain)
2020-05-04 23:40 UTC, Lorenzo Salvadore 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2020-05-04 23:40:19 UTC 
Created attachment 214132 [details]
vulkan-tools log

I am trying to install devel/vulkan-tools from ports but I get the error "ld: error: undefined symbol: vkCreateXcbKHR". Please see the attached log for more details.

I think this is due to the fact that I want to use it on Wayland only, so I installed vulkan-loader with the following options:
WAYLAND: on
XCB: off
XLIB: off

Also, having CMAKE_OFF= BUILD_WSI_WAYLAND_SUPPORT in devel/vulkan-tools/Makefile probably is not helpful.
Comment 1 Val Packett 2020-05-05 13:08:29 UTC 
The cube demos (in this version at least) do not support X11 and Wayland simultaneously, e.g.:

#if defined(VK_USE_PLATFORM_XLIB_KHR) || defined(VK_USE_PLATFORM_XCB_KHR)
#include <X11/Xutil.h>
#elif defined(VK_USE_PLATFORM_WAYLAND_KHR)
#include <linux/input.h>
#endif

So the tools package does not support a wayland-only loader right now.

I guess you could add options that change CUBE_WSI_SELECTION in cmake and/or make building the cube optional. I would approve patches for this.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-05-14 14:17:05 UTC 
A commit references this bug:

Author: jbeich
Date: Thu May 14 14:16:12 UTC 2020
New revision: 535235
URL: https://svnweb.freebsd.org/changeset/ports/535235

Log:
  devel/vulkan-tools: enable Wayland support

  vkcube still defaults to X11 because (unlike vulkaninfo) it cannot
  support more than 1 WSI at the same time.

  PR:		246199
  Reported by:	salvadore
  Approved by:	Greg V (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D24833

Changes:
  head/devel/vulkan-tools/Makefile
  head/devel/vulkan-tools/files/patch-cube_CMakeLists.txt
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-06-11 19:14:39 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Jun 11 19:13:41 UTC 2020
New revision: 538529
URL: https://svnweb.freebsd.org/changeset/ports/538529

Log:
  devel/vulkan-tools: install vkcube for each backend

  PR:		246199
  Approved by:	Greg V (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D25224

Changes:
  head/devel/vulkan-tools/Makefile
  head/devel/vulkan-tools/pkg-plist