Bug 246219 - multimedia/x264: Hook PGO distfile into makesum
Summary: multimedia/x264: Hook PGO distfile into makesum
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-05 11:56 UTC by Jan Beich
Modified: 2020-05-18 05:44 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+


Attachments
v0 (1.42 KB, patch)
2020-05-05 11:56 UTC, Jan Beich
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2020-05-05 11:56:38 UTC
Created attachment 214153 [details]
v0

To prevent accidents like bug 246217 let's force-enable PGO during "make makesum". Adjusting makesum is not uncommon in the ports tree:

  $ rg -l '^\.\s*if\s*make.*makesum' | sed s,/Makefile,, | sort -u
  Mk/Uses/linux.mk
  astro/geographiclib
  devel/android-tools-adb
  devel/android-tools-fastboot
  devel/arduino-core
  devel/godot
  devel/godot2
  devel/libopenbsd
  editors/openoffice-4
  editors/openoffice-devel
  lang/python-doc-html
  lang/visualworks
  mail/exim
  mail/exim-doc-html
  mail/mutt
  math/cblas
  math/crlibm
  math/lapack
  multimedia/dav1d
  multimedia/ffmpeg
  net/rsync
  textproc/sphinxsearch
  www/browsh
  x11-fonts/fantasque-sans-mono
  x11-toolkits/wlroots
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-05-18 04:55:19 UTC
Thanks Jan
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-05-18 04:55:43 UTC
Comment on attachment 214153 [details]
v0

Approved by: koobs (maintainer)
Comment 3 commit-hook freebsd_committer 2020-05-18 05:44:07 UTC
A commit references this bug:

Author: jbeich
Date: Mon May 18 05:43:24 UTC 2020
New revision: 535719
URL: https://svnweb.freebsd.org/changeset/ports/535719

Log:
  multimedia/x264: hook PGO distfile into makesum

  PR:		246219
  Approved by:	koobs (maintainer)

Changes:
  head/multimedia/x264/Makefile