Created attachment 214191 [details] Patch to 2.0.0 Update to 2.0.0. * use python flavours, remove DEPRECATED Program changelog: - remove support python 2.x - added support python 3.x - many small and bigger fixes, see more: https://github.com/rdiff-backup/rdiff-backup/blob/master/CHANGELOG Ps.: maybe the PORTEPOCH can remove? The package name changed from "rdiff-backup" to "pyXX-rdiff-backup".
Created attachment 214192 [details] Forget diff about setup.py patch
(In reply to Zsolt Udvari from comment #0) If the port only support python 3.x, I guess we should use: USES= python:3.x+ (x is the minimum minor version) instead of: USES= python (which means both python 2 and 3 are supported)
(In reply to Hiroki Tagato from comment #2) You've right. Could you please modify it to 3.5+?
(In reply to Zsolt Udvari from comment #3) Yes, I will do it. Additionally, I will add: USES= localbase instead of directly specifying: CPPFLAGS+= -I${LOCALBASE}/include
(In reply to Hiroki Tagato from comment #4) Right.
Opened a review on Phabricator at the following URL: https://reviews.freebsd.org/D24816
Created attachment 214541 [details] Revised patch Hi, Based on the review at https://reviews.freebsd.org/D24816, I have updated the patch. Can you review this version if it's OK with you? Summary of changes: - Rename portname to py-rdiff-backup following Python Ports Policy[1] - Remove PORTEPOCH due to package name change - Use CHEESESHOP as MASTER_SITES instead of USE_GITHUB as per [1] - Update COMMENT to match the description at PyPi as per [1] - Update LICENSE and LICENSE_FILE based on the info at PyPi - Add autoplist and concurrent to USE_PYTHON as per [1] - Delete MAN1S and DOCS to let autoplist handle these files - Delete pkg-plist in favor of autoplist - Add TEST_DEPENDS and do-test target [1] https://wiki.freebsd.org/Python/PortsPolicy If those changes are acceptable, I will go forward and commit the changes. If you need further changes, please feel free to modify and let me know.
(In reply to Hiroki Tagato from comment #7) BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR} Does it work? I couldn't do it with 'setuptools_scm' right and removed it from dependencies.
Created attachment 214573 [details] Poudriere testport log (In reply to Zsolt Udvari from comment #8) I should have attached a poudriere log. Please check the attached log. The port builds fine with: BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
(In reply to Hiroki Tagato from comment #9) Ok, I think it's right. Thanks for your work!
A commit references this bug: Author: tagattie Date: Sun May 17 08:35:20 UTC 2020 New revision: 535526 URL: https://svnweb.freebsd.org/changeset/ports/535526 Log: - Update to 2.0.0 and undeprecate - Rename portname to py-rdiff-backup following Python Ports Policy[1] - Flavorize - Remove PORTEPOCH due to package name change - Use CHEESESHOP as MASTER_SITES instead of USE_GITHUB as per [1] - Update COMMENT to match the description at PyPi as per [1] - Update LICENSE and LICENSE_FILE based on the info at PyPi - Add autoplist and concurrent to USE_PYTHON as per [1] - Delete MAN1S and DOCS to let autoplist handle these files - Delete pkg-plist in favor of autoplist - Add TEST_DEPENDS and do-test target [1] https://wiki.freebsd.org/Python/PortsPolicy PR: 246250 Submitted by: Zsolt Udvari <uzsolt@uzsolt.hu> (maintainer) Reviewed by: koobs, bapt Approved by: ehaupt (mentor) Changelog: https://github.com/rdiff-backup/rdiff-backup/blob/v2.0.0/CHANGELOG Differential Revision: https://reviews.freebsd.org/D24816 Changes: head/MOVED head/sysutils/Makefile head/sysutils/py-rdiff-backup/ head/sysutils/py-rdiff-backup/Makefile head/sysutils/py-rdiff-backup/distinfo head/sysutils/py-rdiff-backup/files/ head/sysutils/py-rdiff-backup/pkg-plist head/sysutils/rdiff-backup/
Committed, thanks!