Bug 246258 - audio/spotifyd: add -r to daemon
Summary: audio/spotifyd: add -r to daemon
Status: Closed Unable to Reproduce
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
Keywords: needs-patch, needs-qa
Depends on:
Reported: 2020-05-06 15:24 UTC by Daniel Ebdrup Jensen
Modified: 2020-07-17 21:09 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (tobik)

Add +r to the daemon invocation (623 bytes, patch)
2020-05-06 15:24 UTC, Daniel Ebdrup Jensen
tobik: maintainer-approval-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Ebdrup Jensen freebsd_committer 2020-05-06 15:24:58 UTC
Created attachment 214198 [details]
Add +r to the daemon invocation

Since spotifyd apparently suffers from being quite unstable compared to most other daemons, it seems like it'll benefit from being automatically restarted, and since daemon is already being used that task can be accomplished by just adding -r.
Comment 1 Tobias Kortkamp freebsd_committer 2020-05-08 15:26:16 UTC
Comment on attachment 214198 [details]
Add +r to the daemon invocation

Please report whatever unstable behavior you have upstream:

Adding -r like that breaks `service spotifyd stop` and `status`.
This obviously needs to continue to work.
Comment 2 Daniel Ebdrup Jensen freebsd_committer 2020-05-10 10:05:15 UTC
Would it be possible to ask for a debug option for this port, then?
RUSTFLAGS="-g" as an environment variable should be all that's required.
Comment 3 Tobias Kortkamp freebsd_committer 2020-05-10 11:13:54 UTC
No, that's what WITH_DEBUG is for.  It works with spotifyd as much
as it does with any other port.
Comment 4 Daniel Ebdrup Jensen freebsd_committer 2020-05-10 14:02:57 UTC
I guess I was having a senior moment..
As soon as I'd finished sending the email, I remembered WITH_DEBUG - but so far the binary that I built with RUSTFLAGS="-g" hasn't crashed once whereas the official one was crashing pretty regularily.

So it looks like this is going to drag on a bit :/