Bug 246260 - devel/llvm-devel: Update to d80715d1d466cfeca041bc43454a3a371391bba5 (20200506); Add the MLIR option
Summary: devel/llvm-devel: Update to d80715d1d466cfeca041bc43454a3a371391bba5 (2020050...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-06 15:59 UTC by Yuri Victorovich
Modified: 2023-07-11 22:44 UTC (History)
0 users

See Also:
brooks: maintainer-feedback-

Attachments
patch (54.42 KB, patch)
2020-05-06 15:59 UTC, Yuri Victorovich 		no flags Details | Diff
patch (55.56 KB, patch)
2020-05-06 22:28 UTC, Yuri Victorovich 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2020-05-06 15:59:52 UTC 
Created attachment 214200 [details]
patch

MLIR (Multi-Level Intermediate Representation Overview) is a set of IR instructions recently added to LLVM: https://mlir.llvm.org/

The attached patch adds the MLIR option and updates the port.

The LLVM release that is currently in ports doesn't build on FreeBSD with LLVM=ON.
Comment 1 Brooks Davis freebsd_committer freebsd_triage 2020-05-06 18:12:30 UTC 
Some patch issues:
 - No updates to the build-plist code
 - No symlinks for newly installed binaries. Need to add MLIR_COMMANDS variable too Makefile.COMMANDS
 - Unrelated openmp linkage change not documented.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2020-05-06 22:28:59 UTC 
Created attachment 214213 [details]
patch

I fixed the issues that you pointed out.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2020-06-24 02:09:25 UTC 
Are there any other improvements that I cam make in this patch?


Yuri
Comment 4 Brooks Davis freebsd_committer freebsd_triage 2020-06-24 19:26:18 UTC 
Something in the update has broken the LLDB python files part of the plist: "python3.8" can't be hardcoded.

It would be helpful if you could reroll them against the current version without an update to the snapshot so only MLIR related changes are required.  If the current one isn't new enough I can try to get an update out next week (I'm under a deadline at the moment).
Comment 5 Brooks Davis freebsd_committer freebsd_triage 2023-07-11 22:44:40 UTC 
We've had MLIR for quite some time.