Bug 246329 - ports-mgmt/portlint: strange output for multimedia/makemkv
Summary: ports-mgmt/portlint: strange output for multimedia/makemkv
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-09 12:06 UTC by Kurt Jaeger
Modified: 2020-05-21 18:01 UTC (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer 2020-05-09 12:06:31 UTC
Running portlint -vAC gives this strange output in the check for MASTER_SITES:

[...]
OK: seen MASTER_SITES, sanity checking URLs.
OK: URL "http://www.makemkv.com/download/:makemkv" ok.
OK: URL "http://www.makemkv.com/download/old/:makemkv" ok.
OK: non-URL "KERNEL_ORG/linux/kernel/v2.6:linux" ok.
make: Unknown modifier 'b'
OK: non-URL "GNU/binutils:binutils" ok.
make: Unknown modifier 'g'
OK: non-URL "GNU/glibc:glibc" ok.
make: Unknown modifier 'g'
OK: non-URL "GNU/gmp:gmp" ok.
make: Unknown modifier 'm'
OK: non-URL "GNU/mpfr:mpfr" ok.
make: Unknown modifier 'm'
OK: non-URL "GNU/mpc:mpc" ok.
OK: non-URL "GCC/releases/gcc-${GCCVERSION}:gcc" ok.
OK: non-URL "SF/opencore-amr/fdk-aac/:fdkaac" ok.
[...]

This happens somewhere in get_makevar*() ?
Comment 1 Felix Palmen 2020-05-11 19:01:07 UTC
Maybe there is something wrong with the MASTER_SITES? But if so, I don't see it. Still, freshports seems to have problems as well, it shows "There is no master site for this port."

https://www.freshports.org/multimedia/makemkv/
Comment 2 Alex Kozlov freebsd_committer 2020-05-21 18:01:18 UTC
The variables like KERNEL_ORG/GNU/etc needs to be expanded before URL/non-URL check. These make warnings are secondary and is from get_makevar()' make invocation, make assumes letters after ':' are variable modifiers: 
$make -V GNU/binutils:binutils
make: Unknown modifier 'b'