Created attachment 214348 [details]
Patch to fix a number of bugs in cciss_vol_status 1.12
Please find enclosed a simple patch that fixes a number of bugs in cciss_vol_status 1.12:
1. Incorrect usage of "&&" (logical-AND) that should be "&" (bitwise-AND).
2. Off-by-one buffer overrun.
Created attachment 214349 [details]
Version 2 of patch to fix &&/& and writing outside an array
Also fixes a pretty-printing issue (so the output lines up nicely for big disk enclosures.
Since cciss_vol_status seems to have been abandoned upstream, the patch is a good way to keep it working and I appreciate it. However, I do no longer have access to compatible hardware, so I can't test it and must rely completely on the submitter's testing.
Anyway, thanks! Please commit.
Created attachment 215791 [details]
v3 of ports patch for cciss_vol_status
Updated diff that updates the included patch in the Port to fix the problems mentioned here. Also updates the port Makefile to fix a minor warning, and changes MAINTAINER to me (from discussion with the original maintainer that no longer have access to compatible hardware).