Bug 246468 - emulators/open-vm-tools: fails to build after r535238
Summary: emulators/open-vm-tools: fails to build after r535238
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-14 18:41 UTC by Christian Ullrich
Modified: 2020-05-15 04:59 UTC (History)
1 user (show)

See Also:
jpaetzel: maintainer-feedback+


Attachments
poudriere build log (41.71 KB, application/x-gzip)
2020-05-14 18:41 UTC, Christian Ullrich
no flags Details
open-vm-tools.diff (18.84 KB, patch)
2020-05-15 01:58 UTC, Josh Paetzel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ullrich 2020-05-14 18:41:27 UTC
Created attachment 214495 [details]
poudriere build log

After the update of emulators/open-vm-tools to 11.1.0 in r535238, the package phase of the poudriere build fails with both orphaned (staged, but not in plist) and missing (in plist, but not staged) files.

A non-poudriere "make package" fails likewise, the last output lines are:

    ===>  Building package for open-vm-tools-11.1.0,2
    pkg-static: Unable to access file /wrkdirs/usr/ports/emulators/open-vm-tools/work/stage/usr/local/share/vmware-tools/vm-support:No such file or directory
    pkg-static: Warning: @dirrm[try] is deprecated, please use @dir


The orphaned files seem to be new translation files, the missing file is the vm-support script that was moved from $PREFIX/share/vmware-tools to /usr/bin in the new upstream version.

files/patch-scripts_Makefile.am does not apply cleanly anymore.

The poudriere build log is attached.
Comment 1 Josh Paetzel freebsd_committer 2020-05-15 01:58:26 UTC
Created attachment 214509 [details]
open-vm-tools.diff
Comment 2 Josh Paetzel freebsd_committer 2020-05-15 01:59:16 UTC
This patch is approved.
Comment 3 commit-hook freebsd_committer 2020-05-15 03:53:34 UTC
A commit references this bug:

Author: jkim
Date: Fri May 15 03:52:34 UTC 2020
New revision: 535263
URL: https://svnweb.freebsd.org/changeset/ports/535263

Log:
  - Install a script in ${PREFIX}/bin rather than /usr/bin.  Fix plist.
  - Add DOCS option for consistent build.  Documentation was automatically
  built when doxygen was found by the configure script.

  PR:		246468
  Approved by:	jpaetzel (maintainer)

Changes:
  head/emulators/open-vm-tools/Makefile
  head/emulators/open-vm-tools/files/patch-scripts_Makefile.am
  head/emulators/open-vm-tools/pkg-plist