Bug 246474 - www/nextcloud: Fix problem installing talk (occ upgrade failure)
Summary: www/nextcloud: Fix problem installing talk (occ upgrade failure)
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-14 21:47 UTC by Michael Gmelin
Modified: 2020-10-10 23:17 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (brnrd)


Attachments
Patch to fix talk install problem on upgrade (1.22 KB, patch)
2020-05-14 21:47 UTC, Michael Gmelin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin freebsd_committer 2020-05-14 21:47:25 UTC
Created attachment 214506 [details]
Patch to fix talk install problem on upgrade

When upgrading to 18 using "occ upgrade" the following error occurs when upgrading talk:

"Repair error: Repair step 'OCA\Talk\Migration\FixNamespaceInDatabaseTables' is unknown"

This patch pulls in a fix from upstream that corrected the issue for me,
see also https://github.com/nextcloud/server/pull/19433

(I applied this manually)

I did poudriere test build the port from source. I didn't have the time to do full installation afterwards, but I applied the patch itself in production running 18.0.4 and it did the trick.
Comment 1 commit-hook freebsd_committer 2020-05-17 15:31:37 UTC
A commit references this bug:

Author: brnrd
Date: Sun May 17 15:31:08 UTC 2020
New revision: 535555
URL: https://svnweb.freebsd.org/changeset/ports/535555

Log:
  www/nextcloud: Fix install issue Talk app

  PR:		246474
  Submitted by:	grembo

Changes:
  head/www/nextcloud/Makefile
  head/www/nextcloud/files/patch-Issue19433
Comment 2 Bernard Spil freebsd_committer 2020-05-17 18:32:39 UTC
Thanks for the report and fix!
Comment 3 Michael Gmelin freebsd_committer 2020-09-04 14:55:08 UTC
Hi Bernard,

I'm reopening this one, as it turns out that App.php.orig is installed and causes issues:

Technical information
=====================
The following list covers which files have failed the integrity check. Please read
the previous linked documentation to learn more about the errors and how to fix
them.

Results
=======
- core
        - EXTRA_FILE
                - lib/private/AppFramework/App.php.orig

Raw output
==========
Array
(
    [core] => Array
        (
            [EXTRA_FILE] => Array
                (
                    [lib/private/AppFramework/App.php.orig] => Array
                        (
                            [expected] => 
                            [current] => e7f29b21ef5a945d36721a6844fb15bb3caf9cc081cbc91f5f00fbd2e3b22cf6f1bc21799c88d6947aec027d75b7e8c27195d9923689fc4c2e09323932efd3b2
                        )

                )

        )

)

It's a bit similar to the problem we've seen in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245852

The fix is probably quite similar.
Comment 4 Michael Gmelin freebsd_committer 2020-09-04 14:59:43 UTC
Oh, while checking pkg contents (as I removed the offending file locally) I also found this problem:

nextcloud-php73-19.0.0_1: missing file /usr/local/www/nextcloud/config/CAN_INSTALL

# pkg check -s
Checking all packages:  55%
nextcloud-php73-19.0.0_1: missing file /usr/local/www/nextcloud/config/CAN_INSTALL
Checking all packages: 100%

When touching that file, the check runs through okay, which tells me that App.php.orig is not in plist.