Bug 246483 - games/nethack36: Fuller curses interface is not enabled
Summary: games/nethack36: Fuller curses interface is not enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Greg Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-15 13:39 UTC by Eric Hanneken
Modified: 2020-05-16 20:52 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (glewis)


Attachments
Patch to enable Curses interface in nethack36 (1.24 KB, patch)
2020-05-15 13:39 UTC, Eric Hanneken
no flags Details | Diff
TTY interface (20.67 KB, image/png)
2020-05-15 13:48 UTC, Eric Hanneken
no flags Details
Curses splash screen (25.02 KB, image/png)
2020-05-15 13:49 UTC, Eric Hanneken
no flags Details
Curses introduction (46.72 KB, image/png)
2020-05-15 13:50 UTC, Eric Hanneken
no flags Details
Curses interface (18.93 KB, image/png)
2020-05-15 13:50 UTC, Eric Hanneken
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Hanneken 2020-05-15 13:39:23 UTC
Created attachment 214521 [details]
Patch to enable Curses interface in nethack36

By default, NetHack runs with a so-called "TTY" interface. (See https://nethackwiki.com/wiki/TTY.) There is also a fuller-featured "Curses" interface, which is somewhat fancier and supports dynamic window resizing. (See https://nethackwiki.com/wiki/Curses_interface.) Yes, both interfaces are curses-based, but these are the existing names.

To switch to the Curses interface, a user is supposed to add

     OPTIONS=windowtype:curses

to $HOME/.nethackrc. However, when I do this and run nethack I see

     $ nethack

     OPTIONS=windowtype:curses
     * Line 1: Window type curses not recognized.  Choices are:  tty, X11.

     1 error in /home/eric/.nethackrc.


     Hit return to continue:

If I install the -nox11 slave port, I get the same error except X11 is absent from the list of choices. It turns out that the Curses interface isn't being compiled by the port. I have attached a patch to let that happen.
Comment 1 Eric Hanneken 2020-05-15 13:48:56 UTC
Created attachment 214522 [details]
TTY interface
Comment 2 Eric Hanneken 2020-05-15 13:49:44 UTC
Created attachment 214523 [details]
Curses splash screen
Comment 3 Eric Hanneken 2020-05-15 13:50:11 UTC
Created attachment 214524 [details]
Curses introduction
Comment 4 Eric Hanneken 2020-05-15 13:50:45 UTC
Created attachment 214525 [details]
Curses interface
Comment 5 commit-hook freebsd_committer 2020-05-16 20:50:39 UTC
A commit references this bug:

Author: glewis
Date: Sat May 16 20:50:33 UTC 2020
New revision: 535500
URL: https://svnweb.freebsd.org/changeset/ports/535500

Log:
  Enable the "curses" window type

  PR:		246483
  Submitted by:	Eric Hanneken <eric@erichanneken.com>

Changes:
  head/games/nethack36/Makefile
  head/games/nethack36/files/patch-sys-unix-Makefile.src
Comment 6 Greg Lewis freebsd_committer 2020-05-16 20:52:28 UTC
Thanks Eric.  I've committed this sans the pkg-message change.  There are many options as you no doubt are aware and I don't think calling out a single one in pkg-message is the right thing to do.  Maybe pointing to the list of options would be worthwhile.