Bug 246486 - devel/git-bug: Fix termui issue
Summary: devel/git-bug: Fix termui issue
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-05-15 14:37 UTC by Lewis Cook
Modified: 2020-05-15 20:07 UTC (History)
1 user (show)

See Also:


Attachments
git-bug-0.7.1_1.diff (1.59 KB, patch)
2020-05-15 14:37 UTC, Lewis Cook
lcook: maintainer-approval+
Details | Diff
git-bug-0.7.1_1.log (33.59 KB, text/plain)
2020-05-15 14:37 UTC, Lewis Cook
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lewis Cook freebsd_committer freebsd_triage 2020-05-15 14:37:15 UTC
Created attachment 214527 [details]
git-bug-0.7.1_1.diff

Amended:
 * Import upstream fix for termui [1] as mentioned here [2].
   We can now _actually_ use 'git bug termui' without it
   indefinitely hanging.

[1]: https://github.com/nsf/termbox-go/commit/58d4fcbce2a7e6a3a48afbc6b7ec2a916ac33ee0
[2]: https://github.com/MichaelMure/git-bug/issues/387

Tested:
 * portlint: OK (looks fine).
 * testport: OK (poudriere: 3.3.4).
Comment 1 Lewis Cook freebsd_committer freebsd_triage 2020-05-15 14:37:44 UTC
Created attachment 214528 [details]
git-bug-0.7.1_1.log

* Poudriere testport log.
Comment 2 Steve Wills freebsd_committer 2020-05-15 15:09:24 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/146466333
Comment 3 Tobias C. Berner freebsd_committer 2020-05-15 20:07:15 UTC
Committed. Thanks.
Comment 4 commit-hook freebsd_committer 2020-05-15 20:07:24 UTC
A commit references this bug:

Author: tcberner
Date: Fri May 15 20:06:34 UTC 2020
New revision: 535333
URL: https://svnweb.freebsd.org/changeset/ports/535333

Log:
  devel/git-bug: Fix termui issue

  Amended:
   * Import upstream fix for termui [1] as mentioned here [2].
     We can now _actually_ use 'git bug termui' without it
     indefinitely hanging.

  [1]: https://github.com/nsf/termbox-go/commit/58d4fcbce2a7e6a3a48afbc6b7ec2a916ac33ee0
  [2]: https://github.com/MichaelMure/git-bug/issues/387

  PR:		246486
  Submitted by:	Lewis Cook <vulcan@wired.sh> (maintainer)

Changes:
  head/devel/git-bug/Makefile
  head/devel/git-bug/files/
  head/devel/git-bug/files/patch-vendor_github.com_awesome-gocui_termbox-go_api.go