Bug 246498 - x11/sway is broken with wlroots 0.10.1_1
Summary: x11/sway is broken with wlroots 0.10.1_1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-05-16 11:57 UTC by shamaz.mazum
Modified: 2020-05-16 23:25 UTC (History)
1 user (show)

See Also:
jbeich: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shamaz.mazum 2020-05-16 11:57:30 UTC
After wlroots was updated to 0.10.1_1 I can no longer build sway without Xwayland support. Can it be fixed?
Comment 1 commit-hook freebsd_committer 2020-05-16 23:24:51 UTC
A commit references this bug:

Author: jbeich
Date: Sat May 16 23:24:20 UTC 2020
New revision: 535505
URL: https://svnweb.freebsd.org/changeset/ports/535505

Log:
  x11-wm/sway: unbreak X11=off build after r535134

  ../sway/commands/xwayland/scale.c:23:12: error: no member named 'xwayland' in 'struct sway_server'
          if(server.xwayland.wlr_xwayland != NULL) {
             ~~~~~~ ^
  ../sway/commands/xwayland/scale.c:24:3: error: implicit declaration of function 'wlr_xwayland_set_scale' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                  wlr_xwayland_set_scale(server.xwayland.wlr_xwayland, scale);
                  ^
  ../sway/commands/xwayland/scale.c:24:3: note: did you mean 'xwayland_cmd_scale'?
  ../sway/commands/xwayland/scale.c:7:21: note: 'xwayland_cmd_scale' declared here
  struct cmd_results *xwayland_cmd_scale(int argc, char **argv) {
                      ^
  ../sway/commands/xwayland/scale.c:24:33: error: no member named 'xwayland' in 'struct sway_server'
                  wlr_xwayland_set_scale(server.xwayland.wlr_xwayland, scale);
                                         ~~~~~~ ^

  PR:		246498
  Reported by:	shamaz.mazum@gmail.com

Changes:
  head/x11-wm/sway/Makefile
  head/x11-wm/sway/distinfo
Comment 2 Jan Beich freebsd_committer 2020-05-16 23:25:54 UTC
Thanks for reporting. File a new bug if you find another regression.