Bug 246539 - sysutils/node_exporter: relinquish terminal when daemonizing
Summary: sysutils/node_exporter: relinquish terminal when daemonizing
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alan Somers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-18 15:17 UTC by Alan Somers
Modified: 2020-06-26 17:09 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ports)
dor.bsd: maintainer-feedback+

Attachments
Relinquish the terminal when starting node_exporter (1.13 KB, patch)
2020-05-18 15:17 UTC, Alan Somers 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2020-05-18 15:17:13 UTC 
Created attachment 214600 [details]
Relinquish the terminal when starting node_exporter

Node exporter's RC script should relinquish the terminal when daemonizing.  Otherwise any program that starts it (for example, py37-salt) may hang forever.
Comment 1 Alan Somers freebsd_committer freebsd_triage 2020-05-28 20:18:50 UTC 
ping.  Could I please get some feedback from the maintainer for this change?
Comment 2 jevonearth 2020-05-28 23:37:40 UTC 
I'm very sorry, I don't have the bandwidth to review this, or maintain this port. I need to put this port maintainership up for adoption.
Comment 3 David O'Rourke 2020-05-29 17:55:02 UTC 
Hi,

This should be taken care of shortly as a part of the upgrade to 1.0.0 in issue #246791.

Thanks for the patch.

-David
Comment 4 David O'Rourke 2020-05-29 17:55:28 UTC 
Comment on attachment 214600 [details]
Relinquish the terminal when starting node_exporter

Rejecting patch here since it will be added in #246791.
Comment 5 Alan Somers freebsd_committer freebsd_triage 2020-06-26 17:09:20 UTC 
This bug was superseded by 246791