Bug 246595 - multimedia/kodi: update to 18.6
Summary: multimedia/kodi: update to 18.6
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2020-05-20 07:18 UTC by yzrh
Modified: 2020-06-02 18:11 UTC (History)
2 users (show)

See Also:


Attachments
diff against 17.6 (265.32 KB, patch)
2020-05-20 07:18 UTC, yzrh
no flags Details | Diff
poudriere log for 12.1 amd64 (76.64 KB, text/plain)
2020-06-01 10:21 UTC, Fernando Apesteguía
no flags Details
diff against 214686 (3.52 KB, patch)
2020-06-01 20:17 UTC, yzrh
no flags Details | Diff
diff against 215144 (1.21 KB, patch)
2020-06-01 21:28 UTC, yzrh
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yzrh 2020-05-20 07:18:17 UTC
Created attachment 214686 [details]
diff against 17.6

Any feedback is welcome, as kodi is quite complicated. I will gladly revise the patch if necessary.
Comment 1 Fernando Apesteguía freebsd_committer 2020-06-01 10:21:22 UTC
Created attachment 215126 [details]
poudriere log for 12.1 amd64

Sorry for the late reply and thanks a lot for the patch. This is indeed a complex port.

The patch applies cleanly, but it doesn't build. I attached the poudriere log for 12.1 amd64.

Would you have a lookt at this?

Thanks!
Comment 2 Mikael Urankar freebsd_committer 2020-06-01 13:15:00 UTC
You can probably drop rpi support, I think it requires the vc4kms driver now and you dropped all the rpi/freebsd patches.
Comment 3 yzrh 2020-06-01 20:17:12 UTC
Created attachment 215144 [details]
diff against 214686

Thanks for the log. I tested the fix with different combination of options this time, all built fine. RPI target still needs testing, but I don't have one.
Comment 4 yzrh 2020-06-01 21:19:48 UTC
(In reply to Mikael Urankar from comment #2)
The difference between kodi 17 and 18 is huge, even a different build process. Patches for kodi 17 need to be ported. I will cherry-pick a few when I have the time.
Comment 5 yzrh 2020-06-01 21:28:30 UTC
Created attachment 215149 [details]
diff against 215144

Just a quick version bump to 18.7, I did a testport, it builds fine.
Comment 6 Mikael Urankar freebsd_committer 2020-06-02 08:46:07 UTC
(In reply to yzrh from comment #4)
That's wasted time if vc4 kms is mandatory rpi
Comment 7 yzrh 2020-06-02 10:00:14 UTC
(In reply to Mikael Urankar from comment #6)
Does that mean no accelerated graphics on RPI? What about v3d driver in mesa?
Comment 8 Mikael Urankar freebsd_committer 2020-06-02 18:11:24 UTC
(In reply to yzrh from comment #7)
Not on rpi/aarch64