Bug 246598 - net-mgmt/librenms: Fix double logging
Summary: net-mgmt/librenms: Fix double logging
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-20 09:56 UTC by Dries Michiels
Modified: 2020-05-22 16:40 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (dvl)


Attachments
librenms.diff (1.51 KB, patch)
2020-05-20 09:56 UTC, Dries Michiels
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dries Michiels 2020-05-20 09:56:59 UTC
Created attachment 214687 [details]
librenms.diff

This patch adds a new rc_variable: librenms_logflags, which defaults to logging to a logfile. When overwriting this variable from rc.conf by eg "-S -T librenms", this can be used to use syslog instead of direct logfile logging.

I default to logfile logging because not everyone wants to use the same syslog parameters. Also, I don't like ports including syslog or newsyslog sample files because of the various flags people tend to keep consistent. EG compression on or off for newsyslog rotation probably depends on if you have ZFS (already compressed) or UFS.
Comment 1 Dan Langille freebsd_committer 2020-05-22 16:40:00 UTC
I my not get to this until June. PGCon is next week and BSDCan is the week after.

My current priorities are there.