Bug 246605 - devel/cc65: strip binaries, fix examples, add documentation
Summary: devel/cc65: strip binaries, fix examples, add documentation
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-20 15:57 UTC by Felix Palmen
Modified: 2020-05-31 09:42 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (wen)


Attachments
improvements to the port (8.34 KB, patch)
2020-05-20 15:57 UTC, Felix Palmen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Palmen 2020-05-20 15:57:27 UTC
Created attachment 214696 [details]
improvements to the port

Here's a patch improving some aspects of the port:

* binaries are installed stripped
* examples were installed twice so far, only install them when EXAMPLES is set
  in FreeBSD's default location
* When DOCS is set, actually build and install html documentation
* Add a new INFO knob to build and install GNU info pages (in a subdirectory,
  because there are many of them and some have pretty generic names)

Build tested on 13-amd64 with all possible combinations of options, inspecting the contents of the resulting package.

Build tested with default options (all set) on {11.3,12.1,13}-{i386,amd64}.
Comment 1 Felix Palmen 2020-05-20 15:58:46 UTC
The added patch is needed because linuxdoc-tools creates texinfo markup rejected by makeinfo for empty table cells. Probably, upstream is building the docs with different versions of the tools.
Comment 2 Felix Palmen 2020-05-30 21:43:53 UTC
I'd appreciate a little feedback here (sorry for "nagging") -- was it a bad idea to put multiple changes in a single patch?
IMHO, stripping the binaries is a must, and avoiding "double" installation of examples is important as well, while adding the docs is just a suggestion for improvement. Please let me know what you think about it, thanks.
Comment 3 commit-hook freebsd_committer 2020-05-31 09:39:59 UTC
A commit references this bug:

Author: wen
Date: Sun May 31 09:39:21 UTC 2020
New revision: 537143
URL: https://svnweb.freebsd.org/changeset/ports/537143

Log:
  - Strip binaries
  - Add a new INFO option
  - Build and install html documents when DOCS option enabled
  - Fix the problem of examples were installed twice

  PR:		246605
  Submitted by:	felix@palmen-it.de

Changes:
  head/devel/cc65/Makefile
  head/devel/cc65/files/
  head/devel/cc65/files/patch-doc_ca65.sgml
  head/devel/cc65/pkg-plist
Comment 4 Wen Heping freebsd_committer 2020-05-31 09:42:25 UTC
(In reply to Felix Palmen from comment #2)
Sorry for reply so late.
Now it is committed.
Thank you !

wen