Bug 246643 - devel/py-pathtools: always tries to build and install DOCS
Summary: devel/py-pathtools: always tries to build and install DOCS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nicola Vitale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-21 19:21 UTC by Robert Kruus
Modified: 2020-05-26 21:46 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (nivit)


Attachments
Makefile patch (731 bytes, text/plain)
2020-05-21 19:21 UTC, Robert Kruus
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kruus 2020-05-21 19:21:48 UTC
Created attachment 214736 [details]
Makefile patch

With 
devel/py-pathtools > make showconfig
===> The following configuration options are available for py37-pathtools-0.1.2_5:
     DOCS=off: Build and/or install documentation
===> Use 'make config' to modify these settings

the build will fail if py-sphinx is not installed as it always runs post-build and post-install.

Patch adds qualifier for post-build and post install. Also moves OPTIONS_DEFINE further down (as suggested by portlint).
Comment 1 commit-hook freebsd_committer 2020-05-26 21:21:47 UTC
A commit references this bug:

Author: nivit
Date: Tue May 26 21:21:27 UTC 2020
New revision: 536660
URL: https://svnweb.freebsd.org/changeset/ports/536660

Log:
  Fix build when DOCS option is off.

  The build failed if py-sphinx was not installed as it always ran
  post-build and post-install targets.

  This patch also moves OPTIONS_DEFINE further down (as suggested by portlint).

  PR:		246643
  Submitted by:	Robert Kruus <robert.kruus@utoronto.ca>

Changes:
  head/devel/py-pathtools/Makefile
  head/devel/py-pathtools/files/patch-docs__source__conf.py
Comment 2 Nicola Vitale freebsd_committer 2020-05-26 21:46:37 UTC
Committed, thanks!