Bug 246675 - Mk/Uses/meson.mk: Add option to set source path when using Meson
Summary: Mk/Uses/meson.mk: Add option to set source path when using Meson
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: feature, needs-qa
Depends on:
Blocks:
 
Reported: 2020-05-23 07:26 UTC by daniel.engberg.lists
Modified: 2020-06-09 03:29 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
Patch for meson (2.07 KB, patch)
2020-05-23 07:26 UTC, daniel.engberg.lists
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description daniel.engberg.lists 2020-05-23 07:26:46 UTC
Created attachment 214774 [details]
Patch for meson

Ports framework assumes that Meson files are kept in ${WRKSRC} which might not
be true for all projects.

Tested with archivers/zstd with locally patched Makefile
Comment 1 daniel.engberg.lists 2020-05-23 07:33:39 UTC
Not sure why it's assigned to sunpoet@ , sorry about that.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2020-05-23 23:53:12 UTC
(In reply to daniel.engberg.lists from comment #1)

> Not sure why it's assigned to sunpoet@ , sorry about that.

Without putting a pathname in a PR synopsis, the auto-assigner tries to guess what the intention was.  It's not always correct.  Solution: always include <category>/<portname> in the synopsis, or, in this case, the pathname.

-- Mark, as bugmeister
Comment 3 daniel.engberg.lists 2020-06-02 08:59:49 UTC
Hi Koop,

Can you have a look at this?
Comment 4 daniel.engberg.lists 2020-06-08 10:26:34 UTC
"Hint: The syntax of meson is meson [command] [arguments] [options]. The setup command takes a builddir and a srcdir argument. If no srcdir is given Meson will deduce the srcdir based on pwd and the location of meson.build"
Ref: https://mesonbuild.com/Running-Meson.html

Previous revision of documentation lists it more clearly.

"Hint: The syntax of meson is meson [options] [srcdir] [builddir], but you may omit either srcdir or builddir. Meson will deduce the srcdir by the location of meson.build. The other one will be your pwd."
Ref: https://github.com/mesonbuild/meson/blob/fb05733983fb06ee3d808c945d4df0050fd3e7bf/docs/markdown/Running-Meson.md
Comment 5 daniel.engberg.lists 2020-06-09 00:23:06 UTC
This seems to be more or less discouraged usage so I'll close it for now as you can work around it in most cases.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2020-06-09 03:29:22 UTC
^Triage Corret (more precise) resolution