Bug 246690 - www/firefox: build fails with nss 3.51
Summary: www/firefox: build fails with nss 3.51
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords: regression
Depends on:
Blocks: 246363
  Show dependency treegraph
 
Reported: 2020-05-24 09:39 UTC by Mikael Urankar
Modified: 2020-05-24 09:51 UTC (History)
0 users

See Also:
jbeich: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer 2020-05-24 09:39:34 UTC
/usr/local/bin/clang90 -std=gnu99 -o Unified_c_netwerk_srtp_src0.o -c  -I/usr/ports/www/firefox/work/.build/dist/system_wrappers -include /usr/ports/www/firefox/work/firefox-76.0.1/config/g
cc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_FREEBSD=1 -DOS_BSD=1 '-DPACKAGE_STRING="libsrtp2 2.2.0-pre"' '-DPACKAGE_V
ERSION="2.2.0-pre"' -DHAVE_CONFIG_H=1 -DHAVE_STDLIB_H=1 -DHAVE_UINT8_T=1 -DHAVE_UINT16_T=1 -DHAVE_INT32_T=1 -DHAVE_UINT32_T=1 -DHAVE_UINT64_T=1 -DGCM=1 -DNSS=1 -DCPU_RISC=1 -DHAVE_NETINET_I
N_H=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/usr/ports/www/firefox/work/firefox-76.0.1/netwerk/srtp/src -I/usr/ports/www/firefox/work/.build/ne
twerk/srtp/src -I/usr/ports/www/firefox/work/.build/ipc/ipdl/_ipdlheaders -I/usr/ports/www/firefox/work/firefox-76.0.1/ipc/chromium/src -I/usr/ports/www/firefox/work/firefox-76.0.1/ipc/glue
 -I/usr/ports/www/firefox/work/firefox-76.0.1/netwerk/srtp/src/crypto/include -I/usr/ports/www/firefox/work/firefox-76.0.1/netwerk/srtp/src/include -I/usr/ports/www/firefox/work/.build/dist
/include -I/usr/local/include/nspr -I/usr/local/include -I/usr/local/include/nss -I/usr/ports/www/firefox/work/.build/dist/include/nss -I/usr/local/include -I/usr/local/include -I/usr/local
/include/pixman-1 -fPIC -include /usr/ports/www/firefox/work/.build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -DLIBICONV_PLUG -isystem /usr/local/include -O2 -pipe -O3 -DLIBICONV
_PLUG -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -fPIC -pipe -I/usr/local/include -O2
 -O3 -fno-omit-frame-pointer -funwind-tables -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Ws
ign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wstring-conversion -Wtautological
-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-error=deprecated-declarations -Wno-error=arra
y-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -std=gnu99 -fexperimental-new-pas
s-manager  -MD -MP -MF .deps/Unified_c_netwerk_srtp_src0.o.pp   Unified_c_netwerk_srtp_src0.c
netwerk/srtp/src/Unified_c_netwerk_srtp_src1.o
In file included from Unified_c_netwerk_srtp_src0.c:2:
/usr/ports/www/firefox/work/firefox-76.0.1/netwerk/srtp/src/crypto/cipher/aes_gcm_nss.c:274:15: error: no member named 'ulIvBits' in 'struct CK_GCM_PARAMS'
    c->params.ulIvBits = GCM_IV_LEN * 8;
    ~~~~~~~~~ ^
1 error generated.
gmake[5]: *** [/usr/ports/www/firefox/work/firefox-76.0.1/config/rules.mk:673: Unified_c_netwerk_srtp_src0.o] Error 1

seems ok with nss 3.52
Comment 1 commit-hook freebsd_committer 2020-05-24 09:50:32 UTC
A commit references this bug:

Author: jbeich
Date: Sun May 24 09:49:44 UTC 2020
New revision: 536377
URL: https://svnweb.freebsd.org/changeset/ports/536377

Log:
  www/firefox: require new NSS after r534912/r534914

  In file included from Unified_c_netwerk_srtp_src0.c:2:
  netwerk/srtp/src/crypto/cipher/aes_gcm_nss.c:274:15: error: no member named 'ulIvBits' in 'struct CK_GCM_PARAMS'
      c->params.ulIvBits = GCM_IV_LEN * 8;
      ~~~~~~~~~ ^

  PR:		246690
  Reported by:	mikael

Changes:
  head/mail/thunderbird/Makefile
  head/www/firefox/Makefile
  head/www/firefox-esr/Makefile
Comment 2 commit-hook freebsd_committer 2020-05-24 09:50:33 UTC
A commit references this bug:

Author: jbeich
Date: Sun May 24 09:50:12 UTC 2020
New revision: 536378
URL: https://svnweb.freebsd.org/changeset/ports/536378

Log:
  MFH: r536377

  www/firefox: require new NSS after r534912/r534914

  In file included from Unified_c_netwerk_srtp_src0.c:2:
  netwerk/srtp/src/crypto/cipher/aes_gcm_nss.c:274:15: error: no member named 'ulIvBits' in 'struct CK_GCM_PARAMS'
      c->params.ulIvBits = GCM_IV_LEN * 8;
      ~~~~~~~~~ ^

  PR:		246690
  Reported by:	mikael
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2020Q2/
  branches/2020Q2/mail/thunderbird/Makefile
  branches/2020Q2/www/firefox/Makefile
  branches/2020Q2/www/firefox-esr/Makefile