Bug 246732 - devel/p5-Test-More-UTF8: Update to 0.05
Summary: devel/p5-Test-More-UTF8: Update to 0.05
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Sivachenko
URL: https://metacpan.org/release/Test-Mor...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-26 00:53 UTC by Sergei Vyshenski
Modified: 2020-06-01 00:41 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (demon)


Attachments
patch to update the port (1.34 KB, patch)
2020-05-26 00:53 UTC, Sergei Vyshenski
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Vyshenski 2020-05-26 00:53:35 UTC
Created attachment 214857 [details]
patch to update the port

- update 0.04_1 -> 0.05
Changes: https://metacpan.org/changes/distribution/Test-More-UTF8
- add LICENSE_FILE=${WRKSRC}/README, 
	because README contains section "COPYRIGHT & LICENSE", and
	thus README does look like license text :)
- remove BUILD and RUN DEPENDS upon devel/p5-Test-Simple because:
	(1) module Test::Simple is no longer used or declared in this project,
	(2) Test::Simple is a core module since perl v5.6.2.
	Frankly, core module Test::Simple in perl 5.30 has version 1.302162,
	but today's port devel/p5-Test-Simple has version 1.302175. 
	Still it seems that point (1) is more important than point (2).
- add TEST_DEPENDS from:
	devel/p5-Test-Pod
	devel/p5-Test-Pod-Coverage
- "portlint -AC" gives non-relevant warns.
- Tested with:
	12.1-RELEASE-p5 amd64
	poudriere 3.3.4
	perl 5.30.2
	pkg 1.14.4
- built-in perl tests in a clean poudriere jail say: PASS.
Comment 1 Dmitry Sivachenko freebsd_committer 2020-05-31 11:24:55 UTC
Why do you add 
LICENSE_FILE=	${WRKSRC}/README ?

README file is not LICENCE text.
Comment 2 commit-hook freebsd_committer 2020-05-31 11:30:14 UTC
A commit references this bug:

Author: demon
Date: Sun May 31 11:29:36 UTC 2020
New revision: 537156
URL: https://svnweb.freebsd.org/changeset/ports/537156

Log:
  Update to version 0.05.

  PR:		246732
  Submitted by:	Sergei Vyshenski <svysh.fbsd@gmail.com>

Changes:
  head/devel/p5-Test-More-UTF8/Makefile
  head/devel/p5-Test-More-UTF8/distinfo
Comment 3 Sergei Vyshenski 2020-05-31 14:09:42 UTC
(In reply to Dmitry Sivachenko from comment #1)
because README contains section "COPYRIGHT & LICENSE", and
	thus README does look like license text :)
Comment 4 Dmitry Sivachenko freebsd_committer 2020-05-31 15:13:52 UTC
No, README just references standard Perl licence.
LICENSE in Makefile should only be used when software uses non-standard license and
reference the file with license content.
Comment 5 Sergei Vyshenski 2020-06-01 00:41:50 UTC
(In reply to Dmitry Sivachenko from comment #4)
Oh, this is new for me. Thank you. Shall fix it in most of my ports, little by little. 

Do you think that such an important rule should be explicitly stated in the PHB? Present version of section 5.7.5:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#licenses-license_file-ex1
seems misleading about this point.